From 8aef73cc99dd9dd85217b101039a61b4a879698c Mon Sep 17 00:00:00 2001 From: Ned Batchelder Date: Thu, 11 Mar 2021 05:25:49 -0500 Subject: test: skip a test on pypy I thought I knew when this passed and when it failed. Now that our tests are not TestCase's, pytest is enforcing the xfails. This passes locally on Mac, but fails in CI on Mac. So skip it. --- tests/test_process.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/test_process.py b/tests/test_process.py index 43a404d5..73c4713a 100644 --- a/tests/test_process.py +++ b/tests/test_process.py @@ -23,7 +23,7 @@ from coverage.data import line_counts from coverage.files import abs_file, python_reported_file from coverage.misc import output_encoding -from tests.coveragetest import CoverageTest, TESTS_DIR, xfail +from tests.coveragetest import CoverageTest, TESTS_DIR from tests.helpers import re_lines @@ -758,10 +758,9 @@ class ProcessTest(CoverageTest): # about 5. assert line_counts(data)['os.py'] > 50 - @xfail( - env.PYPY3 and (env.PYPYVERSION >= (7, 1, 1)), - "https://foss.heptapod.net/pypy/pypy/-/issues/3074" - ) + # Pypy passes locally, but fails in CI? Perhaps the version of macOS is + # significant? https://foss.heptapod.net/pypy/pypy/-/issues/3074 + @pytest.mark.skipif(env.PYPY3, reason="Pypy is unreliable with this test") # Jython as of 2.7.1rc3 won't compile a filename that isn't utf8. @pytest.mark.skipif(env.JYTHON, reason="Jython can't handle this test") def test_lang_c(self): -- cgit v1.2.1