From c1fce712bea25d2fb33b843ccc8f4cd0fca7361d Mon Sep 17 00:00:00 2001 From: Jonathan Hilliard Date: Tue, 28 Jan 2020 15:06:11 -0600 Subject: Added comment. --- jsonpatch.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/jsonpatch.py b/jsonpatch.py index 5454f56..83a04a5 100644 --- a/jsonpatch.py +++ b/jsonpatch.py @@ -825,6 +825,13 @@ class DiffBuilder(object): isinstance(dst, MutableSequence): self._compare_lists(_path_join(path, key), src, dst) + # To ensure we catch changes to JSON, we can't rely on a simple + # src == dst, or it would not recognize the difference between + # 1 and True, among other things. Using json.dumps is the most + # fool-proof way to ensure we catch type changes that matter to JSON + # and ignore those that don't. The performance of this could be + # improved by doing more direct type checks, but we'd need to be + # careful to accept type changes that don't matter when JSONified. elif json.dumps(src) == json.dumps(dst): return -- cgit v1.2.1