shell command now uses cmd.Cmd.stdout for output

The main advantages of this are that shell command output can now be

- piped to another shell command
- redirected to a file

In the future, I may take it a step further where the output is piped, but using a pipe versus a real terminal changes the behavior of many shell commands, for example by getting rid of ANSI color and various other pretty formatting.

1 files changed, 1 insertions, 3 deletions

diff --git a/tests/test_cmd2.py b/tests/test_cmd2.py
index 592e6af2..9dd2697b 100644
--- a/tests/test_cmd2.py
+++ b/tests/test_cmd2.py
@@ -103,12 +103,10 @@ To enable full traceback, run the following command:  'set debug true'
 
 def test_base_shell(base_app, monkeypatch):
     m = mock.Mock()
-    monkeypatch.setattr("os.system", m)
+    monkeypatch.setattr("subprocess.Popen", m)
     out = run_cmd(base_app, 'shell echo a')
     assert out == []
     assert m.called
-    m.assert_called_with('echo a')
-
 
 def test_base_py(base_app, capsys):
     run_cmd(base_app, 'py qqq=3')