summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--CHANGELOG.md5
-rw-r--r--cmd2/cmd2.py16
2 files changed, 12 insertions, 9 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0c423836..d773f784 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,9 +1,8 @@
## 0.9.22 (TBD, 2019)
* Bug Fixes
* Fixed bug where a redefined `ansi.style_error` was not being used in all `cmd2` files
-* Other
- * Removed `bold=True` from `ansi.style_success` because it was difficult for red-greed colorblind users to
- distinguish that color from the `ansi.style_warning` color in certain terminals.
+* Enhancements
+ * Enabled line buffering when redirecting output to a file
## 0.9.21 (November 26, 2019)
* Bug Fixes
diff --git a/cmd2/cmd2.py b/cmd2/cmd2.py
index 753fb5ab..127a8bac 100644
--- a/cmd2/cmd2.py
+++ b/cmd2/cmd2.py
@@ -1874,22 +1874,26 @@ class Cmd(cmd.Cmd):
self.perror("Cannot redirect to paste buffer; missing 'pyperclip' and/or pyperclip dependencies")
redir_error = True
+ # Redirecting to a file
elif statement.output_to:
- # going to a file
- mode = 'w'
- # statement.output can only contain
- # REDIRECTION_APPEND or REDIRECTION_OUTPUT
+ # statement.output can only contain REDIRECTION_APPEND or REDIRECTION_OUTPUT
if statement.output == constants.REDIRECTION_APPEND:
mode = 'a'
+ else:
+ mode = 'w'
+ mode += 't'
+
try:
- new_stdout = open(utils.strip_quotes(statement.output_to), mode)
+ # Use line buffering
+ new_stdout = open(utils.strip_quotes(statement.output_to), mode=mode, buffering=1)
saved_state.redirecting = True
sys.stdout = self.stdout = new_stdout
except OSError as ex:
self.pexcept('Failed to redirect because - {}'.format(ex))
redir_error = True
+
+ # Redirecting to a paste buffer
else:
- # going to a paste buffer
new_stdout = tempfile.TemporaryFile(mode="w+")
saved_state.redirecting = True
sys.stdout = self.stdout = new_stdout