delta/python-packages/eventlet.git/tests/socket_test.py, branch pull-331 github.com: eventlet/eventlet.git socket: family kwarg name compatibility 2016-05-24T08:03:04+00:00 Sergey Shepelev temotor@gmail.com 2016-05-24T07:59:47+00:00 d0837ba1cf8324d678b54567a7570421b7ede18c GreenSocket was (family_or_realsock=AF_INET, ...) which breaks code like socket(family=...) https://github.com/eventlet/eventlet/issues/319 
GreenSocket was (family_or_realsock=AF_INET, ...) which breaks code like socket(family=...)
https://github.com/eventlet/eventlet/issues/319
socket: Actually provide non-blocking DNS methods 2016-05-18T12:24:10+00:00 Jakub Stasiak jakub.stasiak@smarkets.com 2016-05-17T19:16:58+00:00 861d68439949b1f514ab9bbb53958a4592944c4a The green socket module seemed to have only blocking DNS resolution methods even with dnspython installed which is inconsistent with the documentation. This patch has a few consequences: * an import cycle is eliminated * if an import cycle reappears here it'll be visible Note: eliminating the import cycle revealed an issue related to monkey patching and the way we perform greendns tests (the test failures were already present on Python 3.5[1] as that version has some import cycle handling changes). The failures look like this: ====================================================================== FAIL: test_query_ans_types (tests.greendns_test.TestHostsResolver) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/kuba/projects/eventlet/tests/greendns_test.py", line 97, in test_query_ans_types assert isinstance(ans, greendns.dns.resolver.Answer) AssertionError ====================================================================== FAIL: test_query_unknown_no_raise (tests.greendns_test.TestHostsResolver) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/kuba/projects/eventlet/tests/greendns_test.py", line 129, in test_query_unknown_no_raise assert isinstance(ans, greendns.dns.resolver.Answer) AssertionError This issue will be addressed in a separate commit. This patch is contributed by Smarkets Limited. [1] https://github.com/eventlet/eventlet/issues/267 
The green socket module seemed to have only blocking DNS resolution
methods even with dnspython installed which is inconsistent with the
documentation.

This patch has a few consequences:

* an import cycle is eliminated
* if an import cycle reappears here it'll be visible

Note: eliminating the import cycle revealed an issue related to monkey
patching and the way we perform greendns tests (the test failures were
already present on Python 3.5[1] as that version has some import cycle
handling changes). The failures look like this:

======================================================================
FAIL: test_query_ans_types (tests.greendns_test.TestHostsResolver)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/kuba/projects/eventlet/tests/greendns_test.py", line 97, in test_query_ans_types
    assert isinstance(ans, greendns.dns.resolver.Answer)
AssertionError

======================================================================
FAIL: test_query_unknown_no_raise (tests.greendns_test.TestHostsResolver)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/kuba/projects/eventlet/tests/greendns_test.py", line 129, in test_query_unknown_no_raise
    assert isinstance(ans, greendns.dns.resolver.Answer)
AssertionError

This issue will be addressed in a separate commit.

This patch is contributed by Smarkets Limited.

[1] https://github.com/eventlet/eventlet/issues/267
greenio: socket.recv() could return str; Thanks to jerzyk 2015-09-06T00:43:42+00:00 Sergey Shepelev temotor@gmail.com 2015-09-06T00:43:42+00:00 001f31f8f8dfc581795f282609027b26c8a31833 It must always return bytes. https://github.com/eventlet/eventlet/issues/245 
It must always return bytes.
https://github.com/eventlet/eventlet/issues/245
green.socket: create_connection: UnboundLocalError on Python3 2014-09-04T22:50:00+00:00 Sergey Shepelev temotor@gmail.com 2014-09-04T22:49:43+00:00 9d05c68fa209d73ef164909f8c8173d3e67deafb Fixes https://github.com/eventlet/eventlet/issues/123 
Fixes https://github.com/eventlet/eventlet/issues/123