diff options
| author | Ian Cordasco <graffatcolmingov@gmail.com> | 2016-11-09 18:43:42 -0600 |
|---|---|---|
| committer | Ian Cordasco <graffatcolmingov@gmail.com> | 2016-11-09 18:47:57 -0600 |
| commit | 1dfd6bae771619386f7251c3c8281cbb81486b95 (patch) | |
| tree | 0254c8120370032cc34e07c7ef2f43ba675beeaf /src/flake8/plugins | |
| parent | ca4f631fb2411d6f9fbf73ed10275ba8d19dd278 (diff) | |
| download | flake8-1dfd6bae771619386f7251c3c8281cbb81486b95.tar.gz | |
Actually remove enabled extensions from ignore list
When we enable a plugin (when it's provided in the --enable-extensions)
plugin, we need to remove it both from the extended default ignore list
and the plain ignore list.
Closes #239
Diffstat (limited to 'src/flake8/plugins')
| -rw-r--r-- | src/flake8/plugins/manager.py | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/flake8/plugins/manager.py b/src/flake8/plugins/manager.py index a5f1c3b..52b658c 100644 --- a/src/flake8/plugins/manager.py +++ b/src/flake8/plugins/manager.py @@ -182,10 +182,17 @@ class Plugin(object): LOG.critical(str(failed_to_load)) raise failed_to_load - def enable(self, optmanager): + def enable(self, optmanager, options=None): """Remove plugin name from the default ignore list.""" optmanager.remove_from_default_ignore([self.name]) optmanager.extend_default_select([self.name]) + if not options: + return + try: + options.ignore.remove(self.name) + except (ValueError, KeyError): + LOG.debug('Attempted to remove %s from the ignore list but it was ' + 'not a member of the list.', self.name) def disable(self, optmanager): """Add the plugin name to the default ignore list.""" @@ -202,7 +209,7 @@ class Plugin(object): parse_options(options) if self.name in options.enable_extensions: - self.enable(optmanager) + self.enable(optmanager, options) def register_options(self, optmanager): """Register the plugin's command-line options on the OptionManager. |
