summaryrefslogtreecommitdiff
path: root/src/flake8
diff options
context:
space:
mode:
authorJon Dufresne <jon.dufresne@gmail.com>2017-05-01 07:03:21 -0700
committerJon Dufresne <jon.dufresne@gmail.com>2017-05-13 07:14:41 -0700
commit541bac6a824d2308d138df1f92458159c54ea7bc (patch)
tree5960b3ed7e224e599fb87703874676608043fdc8 /src/flake8
parent23b1f37ffd4c69a867aff87079c9fae2b5004155 (diff)
downloadflake8-541bac6a824d2308d138df1f92458159c54ea7bc.tar.gz
Clean up some uses of set, list, and dict
* Use set literals instead of set([...]) * Avoid list(sorted(...)) as sorted returns a list * Replace dict() with dict literal
Diffstat (limited to 'src/flake8')
-rw-r--r--src/flake8/checker.py4
-rw-r--r--src/flake8/defaults.py2
-rw-r--r--src/flake8/main/application.py2
-rw-r--r--src/flake8/options/config.py4
-rw-r--r--src/flake8/plugins/pyflakes.py58
-rw-r--r--src/flake8/statistics.py2
6 files changed, 36 insertions, 36 deletions
diff --git a/src/flake8/checker.py b/src/flake8/checker.py
index a9d7cad..863024b 100644
--- a/src/flake8/checker.py
+++ b/src/flake8/checker.py
@@ -19,7 +19,7 @@ from flake8 import utils
LOG = logging.getLogger(__name__)
-SERIAL_RETRY_ERRNOS = set([
+SERIAL_RETRY_ERRNOS = {
# ENOSPC: Added by sigmavirus24
# > On some operating systems (OSX), multiprocessing may cause an
# > ENOSPC error while trying to trying to create a Semaphore.
@@ -32,7 +32,7 @@ SERIAL_RETRY_ERRNOS = set([
# on the lines before the error code and always append your error
# code. Further, please always add a trailing `,` to reduce the visual
# noise in diffs.
-])
+}
class Manager(object):
diff --git a/src/flake8/defaults.py b/src/flake8/defaults.py
index 340e8a9..e8c6bfb 100644
--- a/src/flake8/defaults.py
+++ b/src/flake8/defaults.py
@@ -25,7 +25,7 @@ IGNORE = (
SELECT = ('E', 'F', 'W', 'C90')
MAX_LINE_LENGTH = 79
-TRUTHY_VALUES = set(['true', '1', 't'])
+TRUTHY_VALUES = {'true', '1', 't'}
# Other constants
WHITESPACE = frozenset(' \t')
diff --git a/src/flake8/main/application.py b/src/flake8/main/application.py
index fb8df28..d7719e3 100644
--- a/src/flake8/main/application.py
+++ b/src/flake8/main/application.py
@@ -261,7 +261,7 @@ class Application(object):
List of filenames to process
"""
if self.running_against_diff:
- files = list(sorted(self.parsed_diff.keys()))
+ files = sorted(self.parsed_diff.keys())
self.file_checker_manager.start(files)
self.file_checker_manager.run()
LOG.info('Finished running')
diff --git a/src/flake8/options/config.py b/src/flake8/options/config.py
index 8306251..59bf60f 100644
--- a/src/flake8/options/config.py
+++ b/src/flake8/options/config.py
@@ -133,10 +133,10 @@ class MergedConfigParser(object):
#: Set of types that should use the
#: :meth:`~configparser.RawConfigParser.getint` method.
- GETINT_TYPES = set(['int', 'count'])
+ GETINT_TYPES = {'int', 'count'}
#: Set of actions that should use the
#: :meth:`~configparser.RawConfigParser.getbool` method.
- GETBOOL_ACTIONS = set(['store_true', 'store_false'])
+ GETBOOL_ACTIONS = {'store_true', 'store_false'}
def __init__(self, option_manager, extra_config_files=None, args=None):
"""Initialize the MergedConfigParser instance.
diff --git a/src/flake8/plugins/pyflakes.py b/src/flake8/plugins/pyflakes.py
index 65a31d0..bc19291 100644
--- a/src/flake8/plugins/pyflakes.py
+++ b/src/flake8/plugins/pyflakes.py
@@ -17,35 +17,35 @@ import pyflakes.checker
from flake8 import utils
-FLAKE8_PYFLAKES_CODES = dict([line.split()[::-1] for line in (
- 'F401 UnusedImport',
- 'F402 ImportShadowedByLoopVar',
- 'F403 ImportStarUsed',
- 'F404 LateFutureImport',
- 'F405 ImportStarUsage',
- 'F406 ImportStarNotPermitted',
- 'F407 FutureFeatureNotDefined',
- 'F601 MultiValueRepeatedKeyLiteral',
- 'F602 MultiValueRepeatedKeyVariable',
- 'F621 TooManyExpressionsInStarredAssignment',
- 'F622 TwoStarredExpressions',
- 'F631 AssertTuple',
- 'F701 BreakOutsideLoop',
- 'F702 ContinueOutsideLoop',
- 'F703 ContinueInFinally',
- 'F704 YieldOutsideFunction',
- 'F705 ReturnWithArgsInsideGenerator',
- 'F706 ReturnOutsideFunction',
- 'F707 DefaultExceptNotLast',
- 'F721 DoctestSyntaxError',
- 'F811 RedefinedWhileUnused',
- 'F812 RedefinedInListComp',
- 'F821 UndefinedName',
- 'F822 UndefinedExport',
- 'F823 UndefinedLocal',
- 'F831 DuplicateArgument',
- 'F841 UnusedVariable',
-)])
+FLAKE8_PYFLAKES_CODES = {
+ 'UnusedImport': 'F401',
+ 'ImportShadowedByLoopVar': 'F402',
+ 'ImportStarUsed': 'F403',
+ 'LateFutureImport': 'F404',
+ 'ImportStarUsage': 'F405',
+ 'ImportStarNotPermitted': 'F406',
+ 'FutureFeatureNotDefined': 'F407',
+ 'MultiValueRepeatedKeyLiteral': 'F601',
+ 'MultiValueRepeatedKeyVariable': 'F602',
+ 'TooManyExpressionsInStarredAssignment': 'F621',
+ 'TwoStarredExpressions': 'F622',
+ 'AssertTuple': 'F631',
+ 'BreakOutsideLoop': 'F701',
+ 'ContinueOutsideLoop': 'F702',
+ 'ContinueInFinally': 'F703',
+ 'YieldOutsideFunction': 'F704',
+ 'ReturnWithArgsInsideGenerator': 'F705',
+ 'ReturnOutsideFunction': 'F706',
+ 'DefaultExceptNotLast': 'F707',
+ 'DoctestSyntaxError': 'F721',
+ 'RedefinedWhileUnused': 'F811',
+ 'RedefinedInListComp': 'F812',
+ 'UndefinedName': 'F821',
+ 'UndefinedExport': 'F822',
+ 'UndefinedLocal': 'F823',
+ 'DuplicateArgument': 'F831',
+ 'UnusedVariable': 'F841',
+}
def patch_pyflakes():
diff --git a/src/flake8/statistics.py b/src/flake8/statistics.py
index d35d4bf..45a7eb1 100644
--- a/src/flake8/statistics.py
+++ b/src/flake8/statistics.py
@@ -17,7 +17,7 @@ class Statistics(object):
:rtype:
list(str)
"""
- return list(sorted(set(key.code for key in self._store.keys())))
+ return sorted({key.code for key in self._store.keys()})
def record(self, error):
"""Add the fact that the error was seen in the file.