summaryrefslogtreecommitdiff
path: root/tests/unit
diff options
context:
space:
mode:
authorEric N. Vander Weele <ericvw@gmail.com>2019-11-01 22:19:15 -0400
committerEric N. Vander Weele <ericvw@gmail.com>2019-11-03 01:34:38 +0800
commit1abe1d42c206f383d863ba97b781646942e9cd8a (patch)
treed75d116d18ecf92cf75f6e80a252faf081b63182 /tests/unit
parentb5157e194d89051f39826d28260f1997ec412908 (diff)
downloadflake8-1abe1d42c206f383d863ba97b781646942e9cd8a.tar.gz
application: Rename prelim parsing method to 'parse_preliminary_options'
Positional arguments are not used nor parsed for pre-configuration loading. Thus, renaming the method and updating the docstrings appropriately.
Diffstat (limited to 'tests/unit')
-rw-r--r--tests/unit/test_application.py9
-rw-r--r--tests/unit/test_legacy_api.py7
2 files changed, 5 insertions, 11 deletions
diff --git a/tests/unit/test_application.py b/tests/unit/test_application.py
index 9d4debc..04845a4 100644
--- a/tests/unit/test_application.py
+++ b/tests/unit/test_application.py
@@ -92,7 +92,7 @@ def test_returns_specified_plugin(application):
def test_prelim_opts_args(application):
"""Verify we get sensible prelim opts and args."""
- opts, args = application.parse_preliminary_options_and_args(
+ opts, args = application.parse_preliminary_options(
['--foo', '--verbose', 'src', 'setup.py', '--statistics', '--version'])
assert opts.verbose
@@ -104,10 +104,7 @@ def test_prelim_opts_ignore_help(application):
# GIVEN
# WHEN
- _, args = application.parse_preliminary_options_and_args([
- '--help',
- '-h',
- ])
+ _, args = application.parse_preliminary_options(['--help', '-h'])
# THEN
assert args == ['--help', '-h']
@@ -117,6 +114,6 @@ def test_prelim_opts_handles_empty(application):
"""Verify empty argv lists are handled correctly."""
irrelevant_args = ['myexe', '/path/to/foo']
with mock.patch.object(sys, 'argv', irrelevant_args):
- opts, args = application.parse_preliminary_options_and_args([])
+ opts, args = application.parse_preliminary_options([])
assert args == []
diff --git a/tests/unit/test_legacy_api.py b/tests/unit/test_legacy_api.py
index 49daf79..071bcf3 100644
--- a/tests/unit/test_legacy_api.py
+++ b/tests/unit/test_legacy_api.py
@@ -18,16 +18,13 @@ def test_get_style_guide():
verbose=0,
)
mockedapp = mock.Mock()
- mockedapp.parse_preliminary_options_and_args.return_value = (
- prelim_opts,
- [],
- )
+ mockedapp.parse_preliminary_options.return_value = (prelim_opts, [])
with mock.patch('flake8.main.application.Application') as application:
application.return_value = mockedapp
style_guide = api.get_style_guide()
application.assert_called_once_with()
- mockedapp.parse_preliminary_options_and_args.assert_called_once_with([])
+ mockedapp.parse_preliminary_options.assert_called_once_with([])
mockedapp.make_config_finder.assert_called_once_with([])
mockedapp.find_plugins.assert_called_once_with(None, False)
mockedapp.register_plugin_options.assert_called_once_with()