diff options
| author | Ian Cordasco <graffatcolmingov@gmail.com> | 2017-06-03 19:20:46 -0500 |
|---|---|---|
| committer | Ian Cordasco <graffatcolmingov@gmail.com> | 2017-06-03 19:20:46 -0500 |
| commit | 65107a5624eb6eb4b1ca78e081b6c66879b77655 (patch) | |
| tree | f6b958a4c9b125b1a3801c1b5e68f225c50ec4d4 /tests/unit | |
| parent | 583fda7a70eb49dcf3b7b83dba0dd646d224592f (diff) | |
| download | flake8-65107a5624eb6eb4b1ca78e081b6c66879b77655.tar.gz | |
Rename methods on the new DecisionEngine
Rename `decision_for` to `more_specific_decision_for` and
`should_report_error` to `decision_for`.
Diffstat (limited to 'tests/unit')
| -rw-r--r-- | tests/unit/test_decision_engine.py | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/tests/unit/test_decision_engine.py b/tests/unit/test_decision_engine.py index 18aca78..aad0176 100644 --- a/tests/unit/test_decision_engine.py +++ b/tests/unit/test_decision_engine.py @@ -118,12 +118,12 @@ def test_was_selected_excludes_errors(select_list, error_code): (defaults.SELECT, defaults.IGNORE, 'E126', style_guide.Decision.Ignored), (defaults.SELECT, defaults.IGNORE, 'W391', style_guide.Decision.Selected), ]) -def test_should_report_error(select_list, ignore_list, error_code, expected): +def test_decision_for(select_list, ignore_list, error_code, expected): """Verify we decide when to report an error.""" decider = style_guide.DecisionEngine(create_options(select=select_list, ignore=ignore_list)) - assert decider.should_report_error(error_code) is expected + assert decider.decision_for(error_code) is expected @pytest.mark.parametrize( @@ -164,9 +164,10 @@ def test_should_report_error(select_list, ignore_list, error_code, expected): style_guide.Decision.Selected), ] ) -def test_decision_for_logic(select, ignore, extend_select, enabled_extensions, - error_code, expected): - """Verify the complicated logic of DecisionEngine.decision_for.""" +def test_more_specific_decision_for_logic(select, ignore, extend_select, + enabled_extensions, error_code, + expected): + """Verify the logic of DecisionEngine.more_specific_decision_for.""" decider = style_guide.DecisionEngine( create_options( select=select, ignore=ignore, @@ -175,4 +176,4 @@ def test_decision_for_logic(select, ignore, extend_select, enabled_extensions, ), ) - assert decider.decision_for(error_code) is expected + assert decider.more_specific_decision_for(error_code) is expected |