diff options
| author | Ian Cordasco <graffatcolmingov@gmail.com> | 2016-06-28 05:47:14 -0500 |
|---|---|---|
| committer | Ian Cordasco <graffatcolmingov@gmail.com> | 2016-06-28 05:47:14 -0500 |
| commit | 31c32e3327c50ff713445280c061bf2c255feb19 (patch) | |
| tree | 4c41a4469331bc6f9cb152dab581143a3153bf8b /tests | |
| parent | 95c373cf112d7415341e97116abacf32757a9391 (diff) | |
| download | flake8-31c32e3327c50ff713445280c061bf2c255feb19.tar.gz | |
Parse hyphenated config names also
Previously Flake8 parsed both
max-line-length = 110
And
max_line_length = 110
From the config file without issue. When we updated our logic, I forgot
to test for that and we lost that behaviour temporarily.
Closes #152
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/fixtures/config_files/config-with-hyphenated-options.ini | 5 | ||||
| -rw-r--r-- | tests/unit/test_merged_config_parser.py | 28 |
2 files changed, 33 insertions, 0 deletions
diff --git a/tests/fixtures/config_files/config-with-hyphenated-options.ini b/tests/fixtures/config_files/config-with-hyphenated-options.ini new file mode 100644 index 0000000..cc0f90e --- /dev/null +++ b/tests/fixtures/config_files/config-with-hyphenated-options.ini @@ -0,0 +1,5 @@ +[flake8] +max-line-length = 110 +enable_extensions = + H101, + H235 diff --git a/tests/unit/test_merged_config_parser.py b/tests/unit/test_merged_config_parser.py index eb57802..1541df4 100644 --- a/tests/unit/test_merged_config_parser.py +++ b/tests/unit/test_merged_config_parser.py @@ -204,3 +204,31 @@ def test_parsed_configs_are_equivalent(optmanager, config_fixture_path): os.path.abspath('bar/'), os.path.abspath('bogus/'), ] + + +@pytest.mark.parametrize('config_file', [ + 'tests/fixtures/config_files/config-with-hyphenated-options.ini' +]) +def test_parsed_hyphenated_and_underscored_names(optmanager, config_file): + """Verify we find hyphenated option names as well as underscored. + + This tests for options like --max-line-length and --enable-extensions + which are able to be specified either as max-line-length or + max_line_length in our config files. + """ + optmanager.add_option('--max-line-length', parse_from_config=True, + type='int') + optmanager.add_option('--enable-extensions', parse_from_config=True, + comma_separated_list=True) + parser = config.MergedConfigParser(optmanager) + config_finder = parser.config_finder + + with mock.patch.object(config_finder, 'local_config_files') as localcfs: + localcfs.return_value = [config_file] + with mock.patch.object(config_finder, + 'user_config_file') as usercf: + usercf.return_value = [] + parsed_config = parser.merge_user_and_local_config() + + assert parsed_config['max_line_length'] == 110 + assert parsed_config['enable_extensions'] == ['H101', 'H235'] |
