summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorEric N. Vander Weele <ericvw@gmail.com>2019-12-01 11:59:12 -0600
committerEric N. Vander Weele <ericvw@gmail.com>2019-12-03 13:21:01 -0500
commit9fa566398627ea5696cc9a526597c500e4278401 (patch)
treef270359db263004ba481a5ca15bec89b0ec2a527 /tests
parent21d2adf21f86471d0bf56e6d444764aa3bb35884 (diff)
downloadflake8-9fa566398627ea5696cc9a526597c500e4278401.tar.gz
application: Inline creation of config.ConfigFileFinder
Simplify the initialization code path by invoking `config.ConfigFileFinder` directly instead of the extra hop by calling the static class-level `Application.make_config_finder()` method.
Diffstat (limited to 'tests')
-rw-r--r--tests/unit/test_legacy_api.py13
1 files changed, 7 insertions, 6 deletions
diff --git a/tests/unit/test_legacy_api.py b/tests/unit/test_legacy_api.py
index 026fdc3..8f6045e 100644
--- a/tests/unit/test_legacy_api.py
+++ b/tests/unit/test_legacy_api.py
@@ -21,15 +21,16 @@ def test_get_style_guide():
mockedapp = mock.Mock()
mockedapp.parse_preliminary_options.return_value = (prelim_opts, [])
mockedapp.program = 'flake8'
- config_finder = ConfigFileFinder(mockedapp.program, [])
- mockedapp.make_config_finder.return_value = config_finder
- with mock.patch('flake8.main.application.Application') as application:
- application.return_value = mockedapp
- style_guide = api.get_style_guide()
+ with mock.patch('flake8.api.legacy.config.ConfigFileFinder') as mock_config_finder: # noqa: E501
+ config_finder = ConfigFileFinder(mockedapp.program, [])
+ mock_config_finder.return_value = config_finder
+
+ with mock.patch('flake8.main.application.Application') as application:
+ application.return_value = mockedapp
+ style_guide = api.get_style_guide()
application.assert_called_once_with()
mockedapp.parse_preliminary_options.assert_called_once_with([])
- mockedapp.make_config_finder.assert_called_once_with(mockedapp.program, [])
mockedapp.find_plugins.assert_called_once_with(config_finder, None, False)
mockedapp.register_plugin_options.assert_called_once_with()
mockedapp.parse_configuration_and_cli.assert_called_once_with(