summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge branch 'config-remove-parent-tail-state' into 'master'Anthony Sottile2020-01-132-10/+8
|\ \ \ | | | | | | | | | | | | | | | | config: Remove ConfigFileFinder 'parent' and 'tail' attributes See merge request pycqa/flake8!400
| * | | config: Remove ConfigFileFinder 'parent' and 'tail' attributesEric N. Vander Weele2020-01-122-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | These attributes are only needed within the `.generate_possible_local_files()` method. Therefore, just obtain the current working directory at the beginning of the method and reduce the lifetime state of the `ConfigFileFinder` object.
| * | | tests: Ensure patched `os.getcwd()` is an absolute pathEric N. Vander Weele2020-01-121-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `os.getcwd()` returns an absolute path; thus, the patched paths should be absolute as well. This is an incremental change towards removing the `ConfigFileFinder` attributes `.parent` and `.tail` to be localized to `.generate_possible_local_files()`. Without this, the tests fail when moving the patching because `os.path.abspath()` calls `os.getcwd()`, expecting `os.getcwd()` to be an absolute path.
* | | | Merge branch 'config-finder-isolated-cleanup' into 'master'Anthony Sottile2020-01-131-3/+0
|\ \ \ \ | |/ / / |/| | | | | | | | | | | application: Remove stale docstring param for `.find_plugins()` See merge request pycqa/flake8!399
| * | | application: Remove stale docstring param for `.find_plugins()`Eric N. Vander Weele2020-01-121-3/+0
| | | | | | | | | | | | | | | | | | | | The 'ignore_config_files' parameter was accidentally not removed in c918e72.
* | | | Merge branch 'config-finder-isolated' into 'master'Anthony Sottile2020-01-089-54/+60
|\ \ \ \ | |/ / / | | | | | | | | | | | | Determine config isolation from the ConfigFileFinder object See merge request pycqa/flake8!398
| * | | Remove unused 'isolated' parameterEric N. Vander Weele2020-01-078-48/+22
| | | | | | | | | | | | | | | | | | | | | | | | Now that `ConfigFileFinder.ignore_config_files` attribute is used everywhere and is constructed from the `--isolated` CLI option, the now unused `isolated` parameters can be safely removed.
| * | | config: Switch code paths to use 'ConfigFileFinder.ignore_config_files'Eric N. Vander Weele2020-01-074-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that the `ConfigFileFinder` has the `.ignore_config_files` attribute, switch the relevant code paths to utilize this public attribute. Tests have been updated to either construct `ConfigFileFinder` or mock the object appropriately.
| * | | config: Add 'ignore_config_files' parameter to ConfigFileFinderEric N. Vander Weele2020-01-073-3/+32
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | The `--isolated` flag is passed into `MergedConfigParser.parse()` and the module-level function `config.get_local_plugins()`. Since both of these places utilize the `ConfigFileFinder` object and isolation pertains to how the `ConfigFileFinder` should behave with respect to isolation, this incremental change more directly associates the `ConfigFileFinder` and configuration file isolate.
* | | Merge branch 'config-read-varargs' into 'master'Anthony Sottile2020-01-073-9/+9
|\ \ \ | | | | | | | | | | | | | | | | config: Change ConfigFileFinder._read_config() to accept variadic args See merge request pycqa/flake8!397
| * | | config: Change ConfigFileFinder._read_config() to accept variadic argsEric N. Vander Weele2020-01-063-9/+9
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This simplifies `._read_config()` by removing a conditional branch in the situation where it is called with one file to process. Now the contract accepts any number of arguments of the same type. Where callers invoke `._read_config()` with a `Sequence`, the call site has been changed to unpack arguments (i.e., `*`). The tests in `test_merged_config_parser.py` needed to return a string for the user configuration path instead of an empty list since `ConfigFileFinder.user_config_file()` returns a string.
* | | Merge branch 'aggregator-config-isolated-fix' into 'master'Anthony Sottile2019-12-306-19/+74
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | aggregator: Forward --config and --isolated options during aggregation Closes #605 See merge request pycqa/flake8!395
| * | | tests: Add integration tests for `--config` and `--isolated`Eric N. Vander Weele2019-12-291-0/+28
| | | | | | | | | | | | | | | | | | | | Prevent regressions by adding integration tests to ensure that these options are passed through to `aggregator.aggregate_options()`.
| * | | aggregator: Forward --config and --isolated options during aggregationEric N. Vander Weele2019-12-295-19/+46
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression introduced in !346 to ensure that `--config` and `--isolated` are recognized in `aggregate_options()`. The regression manifested because `aggregate_options()` was relying on re-parsing `argv` to obtain the option values. However, !346 changed the preliminary parsing logic to only parse and "eat" what is necessary and forward along the options needed before all the configuration was loaded. This code path was overlooked because the tests in `test_aggregator()` were passing but the call from the `Application` object would never have these options in the remaining `argv` list to be passed long.
* | | Merge branch 'app-remove-make-config-finder' into 'master'Anthony Sottile2019-12-034-28/+13
|\ \ \ | | | | | | | | | | | | | | | | application: Inline creation of config.ConfigFileFinder See merge request pycqa/flake8!393
| * | | application: Inline creation of config.ConfigFileFinderEric N. Vander Weele2019-12-034-28/+13
|/ / / | | | | | | | | | | | | | | | Simplify the initialization code path by invoking `config.ConfigFileFinder` directly instead of the extra hop by calling the static class-level `Application.make_config_finder()` method.
* | | Merge branch 'fix/disable_noqa' into 'master'Anthony Sottile2019-12-033-1/+15
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | `--disable-noqa` does not override `# flake8: noqa` Closes #590 See merge request pycqa/flake8!380
| * | | Remove redundant sample dataIsac Yoo2019-11-131-9/+2
| | | |
| * | | Fix codesByeonghoon Yoo2019-11-062-25/+34
| | | |
| * | | Fix lint errorByeonghoon Yoo2019-11-051-1/+2
| | | |
| * | | Add unit test for dd411e95Byeonghoon Yoo2019-11-052-13/+21
| | | |
| * | | Fix should_ignore_file() to handle disable-noqa configurationByeonghoon Yoo2019-11-051-1/+1
| | | |
| * | | Add disable_noqa attribute to FileProcessorByeonghoon Yoo2019-11-051-0/+3
| | | |
* | | | Merge branch 'typo' into 'master'Anthony Sottile2019-12-023-4/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix typos See merge request pycqa/flake8!392
| * | | | Fix typosBrian Wignall2019-12-023-4/+4
|/ / / /
* | | | Merge branch 'fix/exit-zero' into 'master'Anthony Sottile2019-12-022-18/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix --exit-zero when --diff is empty See merge request pycqa/flake8!391
| * | | | Fixes --exit-zero when empty --diffKinya TERASAKA2019-12-022-18/+7
| | | | | | | | | | | | | | | | | | | | fixes pycqa/flake8/merge_requests!137
* | | | | Merge branch 'test_pypy' into 'master'Anthony Sottile2019-11-291-0/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Test pypy in gitlab CI See merge request pycqa/flake8!390
| * | | | | Test pypy in gitlab CIAnthony Sottile2019-11-291-0/+10
|/ / / / /
* | | | | Merge branch 'workaround_pypy_repr_recursion_error' into 'master'Anthony Sottile2019-11-291-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Work around RecursionError in EntryPoint.__repr__ in pypy See merge request pycqa/flake8!389
| * | | | | Work around RecursionError in EntryPoint.__repr__ in pypyAnthony Sottile2019-11-291-1/+1
|/ / / / / | | | | | | | | | | | | | | | https://gitlab.com/python-devs/importlib_metadata/issues/97
* | | | | Merge branch 'importlib_metadata' into 'master'Anthony Sottile2019-11-2912-76/+71
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | Switch from entrypoints to importlib_metadata Closes #569 See merge request pycqa/flake8!388
| * | | | Switch from entrypoints to importlib_metadataAnthony Sottile2019-11-2812-76/+71
|/ / / /
* | | | Merge branch 'app-cleanup-docstrings' into 'master'Anthony Sottile2019-11-271-5/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | application: Update find_plugins() docstring See merge request pycqa/flake8!387
| * | | | application: Update find_plugins() docstringEric N. Vander Weele2019-11-271-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the checks for the cached objects were removed in 2d5eae637a0738d4bad62bed36b57fef07682df6, the `.find_plugins()` docstring need to be updated to specify the updated behavior.
* | | | | Merge branch 'app-remove-local-plugin-attr' into 'master'Anthony Sottile2019-11-271-6/+4
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | application: Remove local plugins state See merge request pycqa/flake8!386
| * | | | application: Remove local plugins stateEric N. Vander Weele2019-11-271-6/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | The `.local_plugins` attribute can be removed from the `Application` since the usage of the `LocalPlugins` object is isolated to the `.find_plugins()` method.
* | | | Merge branch 'application-remove-config-finder-state' into 'master'Anthony Sottile2019-11-223-16/+26
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | application: Remove configuration finder state See merge request pycqa/flake8!384
| * | | | application: Remove configuration finder stateEric N. Vander Weele2019-11-223-16/+26
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | This change removes the `.config_finder` object from the `Application`. Since the configuration finder is only needed during initialization, we constrain the finder to be returned and passed to other methods necessary for initialization.
* | | | Merge branch 'pytest-avoid-5.2.3' into 'master'Anthony Sottile2019-11-151-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tox: Avoid installing pytest==5.2.3 due to an introduced regression Closes #594 See merge request pycqa/flake8!383
| * | | | tox: Avoid installing pytest==5.2.3 due to an introduced regressionEric N. Vander Weele2019-11-151-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | This will ensure that others don't git bitten by accidentally picking up `pytest==5.2.3`. See https://github.com/pytest-dev/pytest/issues/6194.
* | | | Merge branch 'app-make-config-side-effect-free' into 'master'Anthony Sottile2019-11-063-8/+18
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | application: Change `make_config_finder` to be a pure static method See merge request pycqa/flake8!378
| * | | | application: Change `make_config_finder` to be a pure static methodEric N. Vander Weele2019-11-063-8/+18
| |/ / / | | | | | | | | | | | | | | | | This change makes `Application.make_config_finder` to be side-effect free where it its return value is only determined by its input values.
* | | | Merge branch 'app-remove-cached-objects' into 'master'Anthony Sottile2019-11-051-35/+28
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | application: Remove checks for properties being set previously See merge request pycqa/flake8!379
| * | | | application: Remove checks for properties being set previouslyEric N. Vander Weele2019-11-051-35/+28
| |/ / / | | | | | | | | | | | | | | | | | | | | Remove the checks to see an object was already created before creating or obtaining it. This is not necessary as each entire run of `flake8` calls these methods *only* once.
* | | | Merge branch 'py38' into 'master'Anthony Sottile2019-11-055-5/+12
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Cleanup CI and add python 3.8 support See merge request pycqa/flake8!377
| * | | Cleanup CI and add python 3.8 supportDjailla2019-11-055-5/+12
|/ / /
* | | Merge branch 'aggregate_options-simplify-function-definition' into 'master'Anthony Sottile2019-11-031-10/+14
|\ \ \ | | | | | | | | | | | | | | | | aggregator: Simplify 'aggregate_options' function definition See merge request pycqa/flake8!376
| * | | aggregator: Simplify 'aggregate_options' function definitionEric N. Vander Weele2019-11-031-10/+14
|/ / / | | | | | | | | | | | | | | | The `values` parameter is safe to remove since it is not provided as an argument by any callers and the remaining arguments are guaranteed to always be provided by all callers.
* | | Merge branch 'application-argv-required-for-parsing' into 'master'Anthony Sottile2019-11-031-2/+2
|\ \ \ | | | | | | | | | | | | | | | | application: Make 'parse_configuration_and_cli' parameter required See merge request pycqa/flake8!375