| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
| | |
| | |
| | | |
fixes pycqa/flake8/merge_requests!137
|
| | | |
| | |
| | |
| | | |
https://gitlab.com/python-devs/importlib_metadata/issues/97
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | | |
application: Update find_plugins() docstring
See merge request pycqa/flake8!387
|
| | | |
| | |
| | |
| | |
| | |
| | | |
When the checks for the cached objects were removed in
2d5eae637a0738d4bad62bed36b57fef07682df6, the `.find_plugins()`
docstring need to be updated to specify the updated behavior.
|
| |/ /
| |
| |
| |
| |
| | |
The `.local_plugins` attribute can be removed from the `Application`
since the usage of the `LocalPlugins` object is isolated to the
`.find_plugins()` method.
|
| | |
| |
| |
| |
| |
| |
| | |
This change removes the `.config_finder` object from the `Application`.
Since the configuration finder is only needed during initialization, we
constrain the finder to be returned and passed to other methods
necessary for initialization.
|
| |\ \
| | |
| | |
| | |
| | | |
application: Change `make_config_finder` to be a pure static method
See merge request pycqa/flake8!378
|
| | |/
| |
| |
| |
| | |
This change makes `Application.make_config_finder` to be side-effect
free where it its return value is only determined by its input values.
|
| |/
|
|
|
|
| |
Remove the checks to see an object was already created before creating
or obtaining it. This is not necessary as each entire run of `flake8`
calls these methods *only* once.
|
| |
|
|
|
|
| |
The `values` parameter is safe to remove since it is not provided as an
argument by any callers and the remaining arguments are guaranteed to
always be provided by all callers.
|
| |\
| |
| |
| |
| | |
application: Make 'parse_configuration_and_cli' parameter required
See merge request pycqa/flake8!375
|
| | |
| |
| |
| |
| | |
The remaining CLI arguments is now always provided as an argument this
method.
|
| |\ \
| | |
| | |
| | |
| | | |
application: Rename prelim parsing method to 'parse_preliminary_options'
See merge request pycqa/flake8!374
|
| | |/
| |
| |
| |
| |
| | |
Positional arguments are not used nor parsed for pre-configuration
loading. Thus, renaming the method and updating the docstrings
appropriately.
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit simplifies and updates the method for handling the creation
of the configuration file finder. The main takeaways are:
- Renaming the parameter (i.e., `extra_config_files`) to be a noun to
better describe the input versus what the option name was called.
- Refreshed the docstring to align with changes from previous commits
and this one.
- Remove the check to see if it a configuration file finder was already
created. This is not necessary as each entire run of a `flake8` calls
this method once. When the programmatic API is provided,
configuration would be provided 'in-code' and not rely upon external
files/resources.
- Use directly the program name from the `Application`, itself since
this is the authoritative source for defining it.
|
| |
|
|
|
| |
This resets the `black` formatting baseline so it doesn't get picked up
in future commits.
|
| |\
| |
| |
| |
| | |
Separate pre-configuration CLI parsing
See merge request pycqa/flake8!364
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Now that `parse_preliminary_options_and_args()` ignores unknown options
and arguments, forward the remaining unknown arguments to the main CLI
and configuration method to be consumed. This prevents re-parsing the
entire `argv` list again by forwarding the remaining arguments left to
be consumed.
|
| | |
| |
| |
| |
| | |
Now that the preliminary parser is being used, we can remove needing to
prune out `--version` and copying the original `argv` list.
|
| | |
| |
| |
| |
| | |
Now that the preliminary parser is being used, we can remove needing to
prune out `-h` and `--help` from the copied `args` list.
|
| | |
| |
| |
| |
| |
| |
| | |
Positional arguments aren't necessary for determining where to
load configuration anymore and is safe to keep both options and
arguments to be forwarded for later parsing after configuration is
loaded.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Now that preliminary options are registered with the preliminary parser
on the `Application`, leverage that for parsing known options.
This important change removes the `Application.option_manager` from
being responsible for pre-configuration parsing and the workarounds
needed in the `Application.parse_preliminary_options_and_args()` to
account for the fact that `Application.option_manager` was aware of
*all* options, not just the options necessary for pre-configuration
loading. A following commit will address removing these workarounds.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We introduce a new `ArgumentParser` for registering the preliminary
options to be inherited by the `Application.option_manager`. The next
step will be to use the `Application.prelim_arg_parser` for parsing and
handling preliminary options and arguments.
Note that we prevent the preliminary parser from handling `-h/--help`
and defer to that to the primary parser.
|
| | |
| |
| |
| |
| |
| | |
Allow for including options from parent `argparse.ArgumentParser`
objects in preparation of splitting out the handling of preliminary
options from the `OptionManager`.
|
| | |
| |
| |
| |
| | |
This is in preparation for having separate `ArgumentParser`s for
preliminary and the remaining options.
|
| |\ \
| | |
| | |
| | |
| | | |
Merge 3.7.9 tag and release notes
See merge request pycqa/flake8!369
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
In python3.8 on macos and in all versions on windows the multiprocessing
method is `spawn` which does not preserve class state.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Do not pass `noqa` to plugins, have flake8 decide whether to report
Closes #552
See merge request pycqa/flake8!331
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
In python3.8 on macos and in all versions on windows the multiprocessing
method is `spawn` which does not preserve class state.
|
| | |_|/
|/| |
| | |
| | |
| | | |
Also, make appropriate changes to satisfy issues flagged by
`flake8-bugbear`.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The `ConfigFileFinder` doesn't utilize the preliminary arguments (i.e.,
the file names) anymore for computing the starting path for the
configuration file search.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Now that `args` parameters is not being used, it is safe to remove from
the constructor signature.
Further work is required to evaluate and clean-up tearing out the
threading-through of `args` from various callers and tests.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This is the initial incision to only search for configuration relative
to the current working directory where `flake8` is invoked. This brings
configuration file detection closer to other CLI-like programs.
|
| | | |
| | |
| | |
| | | |
This was missed in bb12b83.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
options: Remove parsing `--output-file` from the configuration file
See merge request pycqa/flake8!361
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The `--output-file` option is used when parsing and handling preliminary
options for logging. It is also used to set `BaseFormatter.filename`.
Towards ensuring that the option is respected consistently for both
logging and formatting plugins, only observe the value from the CLI.
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The `--verbose` option is only used by `flake8`, itself,` when parsing
and handling preliminary options. After parsing and merging options
from the configuration file, there is no other behavioral impact to the
core of `flake8`. In other words, setting `verbose = ...` in a
configuration file doesn't change the logging verbosity.
While the `FileProcessor` does expose a `verbose` attribute, obtained
from the parsed options, the verbosity of the core of `flake8` should be
consistent with how a plugin may respond to the attribute's value.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The preliminary options and arguments returned from
`.parse_preliminary_options_and_args()` are now all threaded through to
the appropriate methods during initialization.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The configuration file and boolean to ignore configuration files can be
threaded through now that `.parse_preliminary_options_and_args()`
returns options and arguments.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Now that `.parse_preliminary_options_and_args()` returns options and
arguments, the boolean for appending configuration and the arguments can
be threaded through to the creation of the `ConfigFileFinder`.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The verbosity and output file options can be obtained from options
returned by `.parse_preliminary_options_and_args()`, instead of state
from the `Application` object.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This is the initial step towards removing state from the `Application`
object during argument parsing and handling. The goal is to remove
`Application.prelim_opts` and `Application.prelim_args`.
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Add more type annotations
See merge request pycqa/flake8!353
|
| | | | | |
|
| | | | | |
|
| |/ / / |
|