<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/gitlab.git/gitlab/v4/objects/merge_request_approvals.py, branch renovate/gitlab</title>
<subtitle>github.com: gpocentek/python-gitlab.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/'/>
<entry>
<title>feat: usernames support for MR approvals</title>
<updated>2023-04-19T09:33:26+00:00</updated>
<author>
<name>Nick Brown</name>
<email>nickbroon@graphiant.com</email>
</author>
<published>2023-04-19T08:53:36+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=a2b8c8ccfb5d4fa4d134300861a3bfb0b10246ca'/>
<id>a2b8c8ccfb5d4fa4d134300861a3bfb0b10246ca</id>
<content type='text'>
This can be used instead of 'user_ids'

See: https://docs.gitlab.com/ee/api/merge_request_approvals.html#create-project-level-rule
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This can be used instead of 'user_ids'

See: https://docs.gitlab.com/ee/api/merge_request_approvals.html#create-project-level-rule
</pre>
</div>
</content>
</entry>
<entry>
<title>fix: remove `project.approvals.set_approvals()` method</title>
<updated>2022-10-19T16:37:02+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2022-10-19T16:35:32+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=91f08f01356ca5e38d967700a5da053f05b6fab0'/>
<id>91f08f01356ca5e38d967700a5da053f05b6fab0</id>
<content type='text'>
The `project.approvals.set_approvals()` method used the
`/projects/:id/approvers` end point. That end point was removed from
GitLab in the 13.11 release, on 2-Apr-2021 in commit
27dc2f2fe81249bbdc25f7bd8fe799752aac05e6 via merge commit
e482597a8cf1bae8e27abd6774b684fb90491835. It was deprecated on
19-Aug-2019.

See merge request:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57473
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `project.approvals.set_approvals()` method used the
`/projects/:id/approvers` end point. That end point was removed from
GitLab in the 13.11 release, on 2-Apr-2021 in commit
27dc2f2fe81249bbdc25f7bd8fe799752aac05e6 via merge commit
e482597a8cf1bae8e27abd6774b684fb90491835. It was deprecated on
19-Aug-2019.

See merge request:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57473
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(cli): remove irrelevant MR approval rule list filters</title>
<updated>2022-07-09T15:16:29+00:00</updated>
<author>
<name>Nejc Habjan</name>
<email>nejc.habjan@siemens.com</email>
</author>
<published>2022-07-09T12:31:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=0daec5fa1428a56a6a927b133613e8b296248167'/>
<id>0daec5fa1428a56a6a927b133613e8b296248167</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>feat(api): add support for `get` for a MR approval rule</title>
<updated>2022-06-28T03:42:17+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2022-06-28T03:42:17+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=89c18c6255ec912db319f73f141b47ace87a713b'/>
<id>89c18c6255ec912db319f73f141b47ace87a713b</id>
<content type='text'>
In GitLab 14.10 they added support to get a single merge request
approval rule [1]

Add support for it to ProjectMergeRequestApprovalRuleManager

[1] https://docs.gitlab.com/ee/api/merge_request_approvals.html#get-a-single-merge-request-level-rule
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In GitLab 14.10 they added support to get a single merge request
approval rule [1]

Add support for it to ProjectMergeRequestApprovalRuleManager

[1] https://docs.gitlab.com/ee/api/merge_request_approvals.html#get-a-single-merge-request-level-rule
</pre>
</div>
</content>
</entry>
<entry>
<title>test(pylint): enable pylint "unused-argument" check</title>
<updated>2022-06-27T00:11:21+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2022-06-27T00:11:21+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=23feae9b0906d34043a784a01d31d1ff19ebc9a4'/>
<id>23feae9b0906d34043a784a01d31d1ff19ebc9a4</id>
<content type='text'>
Enable the pylint "unused-argument" check and resolve issues it found.

  * Quite a few functions were accepting `**kwargs` but not then
    passing them on through to the next level. Now pass `**kwargs` to
    next level.
  * Other functions had no reason to accept `**kwargs`, so remove it
  * And a few other fixes.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enable the pylint "unused-argument" check and resolve issues it found.

  * Quite a few functions were accepting `**kwargs` but not then
    passing them on through to the next level. Now pass `**kwargs` to
    next level.
  * Other functions had no reason to accept `**kwargs`, so remove it
  * And a few other fixes.
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: remove no-op id argument in GetWithoutIdMixin</title>
<updated>2022-06-26T01:23:48+00:00</updated>
<author>
<name>Nejc Habjan</name>
<email>nejc.habjan@siemens.com</email>
</author>
<published>2022-05-30T20:58:12+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=0f2a602d3a9d6579f5fdfdf945a236ae44e93a12'/>
<id>0f2a602d3a9d6579f5fdfdf945a236ae44e93a12</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(cli): project-merge-request-approval-rule</title>
<updated>2022-06-18T16:01:20+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2022-06-18T16:01:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=15a242c3303759b77b380c5b3ff9d1e0bf2d800c'/>
<id>15a242c3303759b77b380c5b3ff9d1e0bf2d800c</id>
<content type='text'>
Using the CLI the command:
   gitlab project-merge-request-approval-rule list --mr-iid 1 --project-id foo/bar

Would raise an exception. This was due to the fact that `_id_attr` and
`_repr_attr` were set for keys which are not returned in the response.

Add a unit test which shows the `repr` function now works. Before it
did not.

This is an EE feature so we can't functional test it.

Closes: #2065
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Using the CLI the command:
   gitlab project-merge-request-approval-rule list --mr-iid 1 --project-id foo/bar

Would raise an exception. This was due to the fact that `_id_attr` and
`_repr_attr` were set for keys which are not returned in the response.

Add a unit test which shows the `repr` function now works. Before it
did not.

This is an EE feature so we can't functional test it.

Closes: #2065
</pre>
</div>
</content>
</entry>
<entry>
<title>chore: enable pylint check: "attribute-defined-outside-init"</title>
<updated>2022-06-04T16:18:22+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2022-06-03T23:12:54+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=d6870a981259ee44c64210a756b63dc19a6f3957'/>
<id>d6870a981259ee44c64210a756b63dc19a6f3957</id>
<content type='text'>
Enable the pylint check: "attribute-defined-outside-init" and fix
errors detected.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Enable the pylint check: "attribute-defined-outside-init" and fix
errors detected.
</pre>
</div>
</content>
</entry>
<entry>
<title>chore: move `RequiredOptional` to the `gitlab.types` module</title>
<updated>2022-05-31T14:46:37+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2022-05-31T14:46:37+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=7d26530640eb406479f1604cb64748d278081864'/>
<id>7d26530640eb406479f1604cb64748d278081864</id>
<content type='text'>
By having `RequiredOptional` in the `gitlab.base` module it makes it
difficult with circular imports. Move it to the `gitlab.types`
module which has no dependencies on any other gitlab module.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
By having `RequiredOptional` in the `gitlab.base` module it makes it
difficult with circular imports. Move it to the `gitlab.types`
module which has no dependencies on any other gitlab module.
</pre>
</div>
</content>
</entry>
<entry>
<title>chore: update type-hints return signature for GetWithoutIdMixin methods</title>
<updated>2022-05-30T17:09:43+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2022-05-30T17:09:43+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=aa972d49c57f2ebc983d2de1cfb8d18924af6734'/>
<id>aa972d49c57f2ebc983d2de1cfb8d18924af6734</id>
<content type='text'>
Commit f0152dc3cc9a42aa4dc3c0014b4c29381e9b39d6 removed situation
where `get()` in a `GetWithoutIdMixin` based class could return `None`

Update the type-hints to no longer return `Optional` AKA `None`
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Commit f0152dc3cc9a42aa4dc3c0014b4c29381e9b39d6 removed situation
where `get()` in a `GetWithoutIdMixin` based class could return `None`

Update the type-hints to no longer return `Optional` AKA `None`
</pre>
</div>
</content>
</entry>
</feed>
