<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/gitlab.git/gitlab/v4/objects/merge_requests.py, branch chore/remove-issuesstatistics</title>
<subtitle>github.com: gpocentek/python-gitlab.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/'/>
<entry>
<title>chore: convert to using type-annotations for managers</title>
<updated>2021-09-08T14:18:48+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2021-06-13T21:40:46+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=d8de4dc373dc608be6cf6ba14a2acc7efd3fa7a7'/>
<id>d8de4dc373dc608be6cf6ba14a2acc7efd3fa7a7</id>
<content type='text'>
Convert our manager usage to be done via type annotations.

Now to define a manager to be used in a RESTObject subclass can simply
do:
      class ExampleClass(CRUDMixin, RESTObject):
          my_manager: MyManager

Any type-annotation that annotates it to be of type *Manager (with the
exception of RESTManager) will cause the manager to be created on the
object.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Convert our manager usage to be done via type annotations.

Now to define a manager to be used in a RESTObject subclass can simply
do:
      class ExampleClass(CRUDMixin, RESTObject):
          my_manager: MyManager

Any type-annotation that annotates it to be of type *Manager (with the
exception of RESTManager) will cause the manager to be created on the
object.
</pre>
</div>
</content>
</entry>
<entry>
<title>chore: improve type-hinting for managers</title>
<updated>2021-09-07T15:19:39+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2021-06-12T22:05:36+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=c9b5d3bac8f7c1f779dd57653f718dd0fac4db4b'/>
<id>c9b5d3bac8f7c1f779dd57653f718dd0fac4db4b</id>
<content type='text'>
The 'managers' are dynamically created. This unfortunately means that
we don't have any type-hints for them and so editors which understand
type-hints won't know that they are valid attributes.

 * Add the type-hints for the managers we define.
 * Add a unit test that makes sure that the type-hints and the
   '_managers' attribute are kept in sync with each other.
 * Add unit test that makes sure specified managers in '_managers'
   have a name ending in 'Managers' to keep with current convention.
 * Make RESTObject._managers always present with a default value of
   None.
 * Fix a type-issue revealed now that mypy knows what the type is
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The 'managers' are dynamically created. This unfortunately means that
we don't have any type-hints for them and so editors which understand
type-hints won't know that they are valid attributes.

 * Add the type-hints for the managers we define.
 * Add a unit test that makes sure that the type-hints and the
   '_managers' attribute are kept in sync with each other.
 * Add unit test that makes sure specified managers in '_managers'
   have a name ending in 'Managers' to keep with current convention.
 * Make RESTObject._managers always present with a default value of
   None.
 * Fix a type-issue revealed now that mypy knows what the type is
</pre>
</div>
</content>
</entry>
<entry>
<title>feat(api): add merge_ref for merge requests</title>
<updated>2021-07-21T15:02:57+00:00</updated>
<author>
<name>Matej Focko</name>
<email>mfocko@redhat.com</email>
</author>
<published>2021-07-16T10:02:00+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=1e24ab247cc783ae240e94f6cb379fef1e743a52'/>
<id>1e24ab247cc783ae240e94f6cb379fef1e743a52</id>
<content type='text'>
Support merge_ref on merge requests that returns commit of attempted
merge of the MR.

Signed-off-by: Matej Focko &lt;mfocko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Support merge_ref on merge requests that returns commit of attempted
merge of the MR.

Signed-off-by: Matej Focko &lt;mfocko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1396 from spyoungtech/merge_request_reviewers</title>
<updated>2021-06-26T17:28:39+00:00</updated>
<author>
<name>Nejc Habjan</name>
<email>hab.nejc@gmail.com</email>
</author>
<published>2021-06-26T17:28:39+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=2c86003b36b443203c881dbcefb0ae3908ea1e34'/>
<id>2c86003b36b443203c881dbcefb0ae3908ea1e34</id>
<content type='text'>
feat(api): add support for creating/editing reviewers in project MRs</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
feat(api): add support for creating/editing reviewers in project MRs</pre>
</div>
</content>
</entry>
<entry>
<title>feat(api): remove responsibility for API inconsistencies for MR reviewers</title>
<updated>2021-06-16T19:43:14+00:00</updated>
<author>
<name>Spencer Phillip Young</name>
<email>spencer.young@spyoung.com</email>
</author>
<published>2021-06-16T19:43:14+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=3d985ee8cdd5d27585678f8fbb3eb549818a78eb'/>
<id>3d985ee8cdd5d27585678f8fbb3eb549818a78eb</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>feat(api): add MR pipeline manager in favor of pipelines() method</title>
<updated>2021-06-13T19:18:44+00:00</updated>
<author>
<name>Nejc Habjan</name>
<email>hab.nejc@gmail.com</email>
</author>
<published>2021-02-23T23:18:49+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=954357c49963ef51945c81c41fd4345002f9fb98'/>
<id>954357c49963ef51945c81c41fd4345002f9fb98</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>feat(api): add support for creating/editing reviewers in project merge requests</title>
<updated>2021-05-31T21:16:42+00:00</updated>
<author>
<name>Spencer Young</name>
<email>spencer.young@spyoung.com</email>
</author>
<published>2021-04-14T01:16:32+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=676d1f6565617a28ee84eae20e945f23aaf3d86f'/>
<id>676d1f6565617a28ee84eae20e945f23aaf3d86f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>feat(api): add deployment mergerequests interface</title>
<updated>2021-05-30T22:03:12+00:00</updated>
<author>
<name>Ludwig Weiss</name>
<email>ludwig.weiss@umusic.com</email>
</author>
<published>2020-05-14T08:35:49+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=fbbc0d400015d7366952a66e4401215adff709f0'/>
<id>fbbc0d400015d7366952a66e4401215adff709f0</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fix: change mr.merge() to use 'post_data'</title>
<updated>2021-05-25T21:54:13+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2021-05-23T21:42:44+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=cb6a3c672b9b162f7320c532410713576fbd1cdc'/>
<id>cb6a3c672b9b162f7320c532410713576fbd1cdc</id>
<content type='text'>
MR https://github.com/python-gitlab/python-gitlab/pull/1121 changed
mr.merge() to use 'query_data'. This appears to have been wrong.

From the Gitlab docs they state it should be sent in a payload body
https://docs.gitlab.com/ee/api/README.html#request-payload since
mr.merge() is a PUT request.

  &gt; Request Payload

  &gt; API Requests can use parameters sent as query strings or as a
  &gt; payload body. GET requests usually send a query string, while PUT
  &gt; or POST requests usually send the payload body

Fixes: #1452
Related to: #1120
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
MR https://github.com/python-gitlab/python-gitlab/pull/1121 changed
mr.merge() to use 'query_data'. This appears to have been wrong.

From the Gitlab docs they state it should be sent in a payload body
https://docs.gitlab.com/ee/api/README.html#request-payload since
mr.merge() is a PUT request.

  &gt; Request Payload

  &gt; API Requests can use parameters sent as query strings or as a
  &gt; payload body. GET requests usually send a query string, while PUT
  &gt; or POST requests usually send the payload body

Fixes: #1452
Related to: #1120
</pre>
</div>
</content>
</entry>
<entry>
<title>chore: fix import ordering using isort</title>
<updated>2021-05-25T18:54:51+00:00</updated>
<author>
<name>John L. Villalovos</name>
<email>john@sodarock.com</email>
</author>
<published>2021-05-22T15:55:19+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/gitlab.git/commit/?id=f3afd34260d681bbeec974b67012b90d407b7014'/>
<id>f3afd34260d681bbeec974b67012b90d407b7014</id>
<content type='text'>
Fix the import ordering using isort.

https://pycqa.github.io/isort/
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix the import ordering using isort.

https://pycqa.github.io/isort/
</pre>
</div>
</content>
</entry>
</feed>
