summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNejc Habjan <nejc.habjan@siemens.com>2020-10-29 01:14:30 +0100
committerNejc Habjan <hab.nejc@gmail.com>2021-02-06 11:11:27 +0100
commitf78ebe065f73b29555c2dcf17b462bb1037a153e (patch)
treeaa05be29fececdc25a0f22e3f806b1666460f97d
parente6c20f18f3bd1dabdf181a070b9fdbfe4a442622 (diff)
downloadgitlab-feat/single-issue-api.tar.gz
feat(issues): add missing get verb to IssueManagerfeat/single-issue-api
-rw-r--r--gitlab/tests/objects/test_issues.py23
-rw-r--r--gitlab/v4/objects/__init__.py2
2 files changed, 22 insertions, 3 deletions
diff --git a/gitlab/tests/objects/test_issues.py b/gitlab/tests/objects/test_issues.py
index f67d720..93d8e0c 100644
--- a/gitlab/tests/objects/test_issues.py
+++ b/gitlab/tests/objects/test_issues.py
@@ -9,7 +9,7 @@ from gitlab.v4.objects import ProjectIssuesStatistics
@pytest.fixture
-def resp_issue():
+def resp_list_issues():
content = [{"name": "name", "id": 1}, {"name": "other_name", "id": 2}]
with responses.RequestsMock() as rsps:
@@ -24,6 +24,19 @@ def resp_issue():
@pytest.fixture
+def resp_get_issue():
+ with responses.RequestsMock() as rsps:
+ rsps.add(
+ method=responses.GET,
+ url="http://localhost/api/v4/issues/1",
+ json={"name": "name", "id": 1},
+ content_type="application/json",
+ status=200,
+ )
+ yield rsps
+
+
+@pytest.fixture
def resp_issue_statistics():
content = {"statistics": {"counts": {"all": 20, "closed": 5, "opened": 15}}}
@@ -38,12 +51,18 @@ def resp_issue_statistics():
yield rsps
-def test_issues(gl, resp_issue):
+def test_list_issues(gl, resp_list_issues):
data = gl.issues.list()
assert data[1].id == 2
assert data[1].name == "other_name"
+def test_get_issue(gl, resp_get_issue):
+ issue = gl.issues.get(1)
+ assert issue.id == 1
+ assert issue.name == "name"
+
+
def test_project_issues_statistics(project, resp_issue_statistics):
statistics = project.issuesstatistics.get()
assert isinstance(statistics, ProjectIssuesStatistics)
diff --git a/gitlab/v4/objects/__init__.py b/gitlab/v4/objects/__init__.py
index a69563c..a98481e 100644
--- a/gitlab/v4/objects/__init__.py
+++ b/gitlab/v4/objects/__init__.py
@@ -1641,7 +1641,7 @@ class Issue(RESTObject):
_short_print_attr = "title"
-class IssueManager(ListMixin, RESTManager):
+class IssueManager(RetrieveMixin, RESTManager):
_path = "/issues"
_obj_cls = Issue
_list_filters = (