diff options
| author | Gauvain Pocentek <gauvain@pocentek.net> | 2019-03-03 18:06:48 +0100 |
|---|---|---|
| committer | Gauvain Pocentek <gauvain@pocentek.net> | 2019-03-03 18:06:48 +0100 |
| commit | d74ff506ca0aadaba3221fc54cbebb678240564f (patch) | |
| tree | 0658680e0077e20cbc29992ac96f595a62d9d18e | |
| parent | b21fa2854302ef4d9301242ef719eaa509adf077 (diff) | |
| download | gitlab-fix/699.tar.gz | |
fix(api): Make *MemberManager.all() return a list of objectsfix/699
Fixes #699
| -rw-r--r-- | RELEASE_NOTES.rst | 7 | ||||
| -rw-r--r-- | gitlab/v4/objects.py | 6 |
2 files changed, 11 insertions, 2 deletions
diff --git a/RELEASE_NOTES.rst b/RELEASE_NOTES.rst index 44e457a..4d9e392 100644 --- a/RELEASE_NOTES.rst +++ b/RELEASE_NOTES.rst @@ -4,6 +4,13 @@ Release notes This page describes important changes between python-gitlab releases. +Changes from 1.8 to 1.9 +======================= + +* ``ProjectMemberManager.all()`` and ``GroupMemberManager.all()`` now return a + list of ``ProjectMember`` and ``GroupMember`` objects respectively, instead + of a list of dicts. + Changes from 1.7 to 1.8 ======================= diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py index 8348c76..c3f8a81 100644 --- a/gitlab/v4/objects.py +++ b/gitlab/v4/objects.py @@ -740,7 +740,8 @@ class GroupMemberManager(CRUDMixin, RESTManager): """ path = '%s/all' % self.path - return self.gitlab.http_list(path, **kwargs) + obj = self.gitlab.http_list(path, **kwargs) + return [self._obj_cls(self, item) for item in obj] class GroupMergeRequest(RESTObject): @@ -1955,7 +1956,8 @@ class ProjectMemberManager(CRUDMixin, RESTManager): """ path = '%s/all' % self.path - return self.gitlab.http_list(path, **kwargs) + obj = self.gitlab.http_list(path, **kwargs) + return [self._obj_cls(self, item) for item in obj] class ProjectNote(RESTObject): |