summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Wittig <max.wittig95@gmail.com>2020-03-08 12:03:38 +0100
committerMax Wittig <max.wittig95@gmail.com>2020-03-08 12:03:38 +0100
commitadc91011e46dfce909b7798b1257819ec09d01bd (patch)
tree45010c1ce1e1811e81173f2d8f241835c8aca4fc
parent70c0cfb686177bc17b796bf4d7eea8b784cf9651 (diff)
downloadgitlab-fix/set-approvers.tar.gz
fix(projects): correct copy-paste errorfix/set-approvers
-rw-r--r--gitlab/v4/objects.py2
-rwxr-xr-xtools/ee-test.py4
2 files changed, 3 insertions, 3 deletions
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
index 64442ce..f22229c 100644
--- a/gitlab/v4/objects.py
+++ b/gitlab/v4/objects.py
@@ -2708,7 +2708,7 @@ class ProjectMergeRequestApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTMan
)
data = {
"name": "name",
- "self.assertEqual(expected, actual, 'message')pprovals_required": approvals_required,
+ "approvals_required": approvals_required,
"rule_type": "regular",
"user_ids": approver_ids,
"group_ids": approver_group_ids,
diff --git a/tools/ee-test.py b/tools/ee-test.py
index af12957..3f75655 100755
--- a/tools/ee-test.py
+++ b/tools/ee-test.py
@@ -56,12 +56,12 @@ assert approval.approvers[0]["user"]["id"] == 1
ars = project1.approvalrules.list(all=True)
assert len(ars) == 0
-project.approvalrules.create(
+project1.approvalrules.create(
{"name": "approval-rule", "approvals_required": 1, "group_ids": [group1.id]}
)
ars = project1.approvalrules.list(all=True)
assert len(ars) == 1
-ars[0].approvals_required == 2
+assert ars[0].approvals_required == 2
ars[0].save()
ars = project1.approvalrules.list(all=True)
assert len(ars) == 1