diff options
| author | Nejc Habjan <hab.nejc@gmail.com> | 2021-09-08 23:42:05 +0200 |
|---|---|---|
| committer | Nejc Habjan <hab.nejc@gmail.com> | 2021-09-11 12:02:17 +0200 |
| commit | b8d379d5be016081992c06312d7d4790a5d52bfb (patch) | |
| tree | 6f62a35e235c28b3a289f26c59e0ffbb2d6a619b | |
| parent | 2b8a94a77ba903ae97228e7ffa3cc2bf6ceb19ba (diff) | |
| download | gitlab-refactor/consts-in-const-module.tar.gz | |
refactor(objects): remove deprecated constants defined in objectsrefactor/consts-in-const-module
BREAKING CHANGE: remove deprecated constants defined in
gitlab.v4.objects, and use only gitlab.const module
| -rw-r--r-- | gitlab/const.py | 7 | ||||
| -rw-r--r-- | gitlab/v4/objects/__init__.py | 11 | ||||
| -rw-r--r-- | tests/functional/api/test_snippets.py | 2 |
3 files changed, 4 insertions, 16 deletions
diff --git a/gitlab/const.py b/gitlab/const.py index 095b43d..c57423e 100644 --- a/gitlab/const.py +++ b/gitlab/const.py @@ -25,12 +25,11 @@ GUEST_ACCESS: int = 10 REPORTER_ACCESS: int = 20 DEVELOPER_ACCESS: int = 30 MAINTAINER_ACCESS: int = 40 -MASTER_ACCESS: int = MAINTAINER_ACCESS OWNER_ACCESS: int = 50 -VISIBILITY_PRIVATE: int = 0 -VISIBILITY_INTERNAL: int = 10 -VISIBILITY_PUBLIC: int = 20 +VISIBILITY_PRIVATE: str = "private" +VISIBILITY_INTERNAL: str = "internal" +VISIBILITY_PUBLIC: str = "public" NOTIFICATION_LEVEL_DISABLED: str = "disabled" NOTIFICATION_LEVEL_PARTICIPATING: str = "participating" diff --git a/gitlab/v4/objects/__init__.py b/gitlab/v4/objects/__init__.py index 1b95410..c2ff4fb 100644 --- a/gitlab/v4/objects/__init__.py +++ b/gitlab/v4/objects/__init__.py @@ -74,15 +74,4 @@ from .users import * from .variables import * from .wikis import * -# TODO: deprecate these in favor of gitlab.const.* -VISIBILITY_PRIVATE = "private" -VISIBILITY_INTERNAL = "internal" -VISIBILITY_PUBLIC = "public" - -ACCESS_GUEST = 10 -ACCESS_REPORTER = 20 -ACCESS_DEVELOPER = 30 -ACCESS_MASTER = 40 -ACCESS_OWNER = 50 - __all__ = [name for name in dir() if not name.startswith("_")] diff --git a/tests/functional/api/test_snippets.py b/tests/functional/api/test_snippets.py index 936fbfb..9e0f833 100644 --- a/tests/functional/api/test_snippets.py +++ b/tests/functional/api/test_snippets.py @@ -33,7 +33,7 @@ def test_project_snippets(project): "title": "snip1", "file_name": "foo.py", "content": "initial content", - "visibility": gitlab.v4.objects.VISIBILITY_PRIVATE, + "visibility": gitlab.VISIBILITY_PRIVATE, } ) |