summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn L. Villalovos <john@sodarock.com>2021-04-24 17:12:43 -0700
committerJohn L. Villalovos <john@sodarock.com>2021-04-27 08:19:12 -0700
commit45f806c7a7354592befe58a76b7e33a6d5d0fe6e (patch)
tree3e0f733d0fd39c70ed375a0e23eedf028a036436
parent909aa9a02b8a0eb2faed747bfbf5839c53266129 (diff)
downloadgitlab-45f806c7a7354592befe58a76b7e33a6d5d0fe6e.tar.gz
fix: iids not working as a list in projects.issues.list()
Set the 'iids' values as type ListAttribute so it will pass the list as a comma-separated string, instead of a list. Add a functional test. Closes: #1407
-rw-r--r--gitlab/v4/objects/issues.py2
-rw-r--r--tools/functional/api/test_issues.py6
2 files changed, 6 insertions, 2 deletions
diff --git a/gitlab/v4/objects/issues.py b/gitlab/v4/objects/issues.py
index cdaeaba..c3c35d3 100644
--- a/gitlab/v4/objects/issues.py
+++ b/gitlab/v4/objects/issues.py
@@ -220,7 +220,7 @@ class ProjectIssueManager(CRUDMixin, RESTManager):
"discussion_locked",
),
)
- _types = {"labels": types.ListAttribute}
+ _types = {"iids": types.ListAttribute, "labels": types.ListAttribute}
class ProjectIssueLink(ObjectDeleteMixin, RESTObject):
diff --git a/tools/functional/api/test_issues.py b/tools/functional/api/test_issues.py
index ebff72b..6ab4b33 100644
--- a/tools/functional/api/test_issues.py
+++ b/tools/functional/api/test_issues.py
@@ -4,7 +4,11 @@ import gitlab
def test_create_issue(project):
issue = project.issues.create({"title": "my issue 1"})
issue2 = project.issues.create({"title": "my issue 2"})
- assert len(project.issues.list()) == 2
+ issue_ids = [issue.id for issue in project.issues.list()]
+ assert len(issue_ids) == 2
+
+ # Test 'iids' as a list
+ assert len(project.issues.list(iids=issue_ids)) == 2
issue2.state_event = "close"
issue2.save()