summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNejc Habjan <hab.nejc@gmail.com>2020-03-28 17:37:39 +0100
committerNejc Habjan <hab.nejc@gmail.com>2020-03-28 17:59:07 +0100
commitbabd298eca0586dce134d65586bf50410aacd035 (patch)
treee6f3b32a4c1a106d67c1b0616118db5a2a43ff50
parentc5904c4c2e79ec302ff0de20bcb2792be4924bbe (diff)
downloadgitlab-babd298eca0586dce134d65586bf50410aacd035.tar.gz
test(types): reproduce get_for_api splitting strings (#1057)
-rw-r--r--gitlab/tests/test_types.py10
-rw-r--r--tools/python_test_v4.py9
2 files changed, 17 insertions, 2 deletions
diff --git a/gitlab/tests/test_types.py b/gitlab/tests/test_types.py
index 5b9f2ca..3613383 100644
--- a/gitlab/tests/test_types.py
+++ b/gitlab/tests/test_types.py
@@ -51,11 +51,19 @@ class TestListAttribute(unittest.TestCase):
o.set_from_cli(" ")
self.assertEqual([], o.get())
- def test_get_for_api(self):
+ def test_get_for_api_from_cli(self):
o = types.ListAttribute()
o.set_from_cli("foo,bar,baz")
self.assertEqual("foo,bar,baz", o.get_for_api())
+ def test_get_for_api_from_list(self):
+ o = types.ListAttribute(["foo", "bar", "baz"])
+ self.assertEqual("foo,bar,baz", o.get_for_api())
+
+ def test_get_for_api_does_not_split_string(self):
+ o = types.ListAttribute("foo")
+ self.assertEqual("foo", o.get_for_api())
+
class TestLowercaseStringAttribute(unittest.TestCase):
def test_get_for_api(self):
diff --git a/tools/python_test_v4.py b/tools/python_test_v4.py
index 69b0d31..e0cb3a6 100644
--- a/tools/python_test_v4.py
+++ b/tools/python_test_v4.py
@@ -677,10 +677,17 @@ assert issue1.participants()
assert type(issue1.closed_by()) == list
assert type(issue1.related_merge_requests()) == list
-# issues labels and events
+# issue labels
label2 = admin_project.labels.create({"name": "label2", "color": "#aabbcc"})
issue1.labels = ["label2"]
issue1.save()
+
+assert issue1 in admin_project.issues.list(labels=["label2"])
+assert issue1 in admin_project.issues.list(labels="label2")
+assert issue1 in admin_project.issues.list(labels="Any")
+assert issue1 not in admin_project.issues.list(labels="None")
+
+# issue events
events = issue1.resourcelabelevents.list()
assert events
event = issue1.resourcelabelevents.get(events[0].id)