diff options
author | John L. Villalovos <john@sodarock.com> | 2021-12-30 12:34:50 -0800 |
---|---|---|
committer | John L. Villalovos <john@sodarock.com> | 2021-12-30 12:34:50 -0800 |
commit | cb824a49af9b0d155b89fe66a4cfebefe52beb7a (patch) | |
tree | e2227ebe783649de4c4b8a1b45ac4a9bc9e18a6a /gitlab/base.py | |
parent | 501f9a1588db90e6d2c235723ba62c09a669b5d2 (diff) | |
download | gitlab-jlvillal/pagination.tar.gz |
fix: handle situation where GitLab does not return valuesjlvillal/pagination
If a query returns more than 10,000 records than the following values
are NOT returned:
x.total_pages
x.total
Modify the code to allow no value to be set for these values. If there
is not a value returned the functions will now return None.
Update unit test so no longer `xfail`
https://docs.gitlab.com/ee/user/gitlab_com/index.html#pagination-response-headers
Closes #1686
Diffstat (limited to 'gitlab/base.py')
-rw-r--r-- | gitlab/base.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gitlab/base.py b/gitlab/base.py index 64604b4..50f09c5 100644 --- a/gitlab/base.py +++ b/gitlab/base.py @@ -288,12 +288,12 @@ class RESTObjectList(object): return self._list.per_page @property - def total_pages(self) -> int: + def total_pages(self) -> Optional[int]: """The total number of pages.""" return self._list.total_pages @property - def total(self) -> int: + def total(self) -> Optional[int]: """The total number of items.""" return self._list.total |