fix: use the [] after key names for array variablesjlvillal/arrays

1. Create a new CommaSeparatedListAttribute class. This is to indicate
   types which are sent to the GitLab server as
   comma-separated-strings (CSV) but we have been allowing users to
   use a list-of-strings.  These values are NOT array values, so
   adding [] to the key name breaks them.

2. Rename ListAttribute to ArrayAttribute.

3. If a value is of type ArrayAttribute then append '[]' to the name
   of the value.

4. Move processing of most GitlabAttributes into the
   client.py:http_request() method. Now we convert our params into a
   list of tuples so that we can have multiple identical keys but with
   different values.

Fixes: #1698

1 files changed, 2 insertions, 2 deletions

diff --git a/gitlab/v4/objects/groups.py b/gitlab/v4/objects/groups.py
index f2b90d1..99d10ce 100644
--- a/gitlab/v4/objects/groups.py
+++ b/gitlab/v4/objects/groups.py
@@ -314,7 +314,7 @@ class GroupManager(CRUDMixin, RESTManager):
             "shared_runners_setting",
         ),
     )
-    _types = {"avatar": types.ImageAttribute, "skip_groups": types.ListAttribute}
+    _types = {"avatar": types.ImageAttribute, "skip_groups": types.ArrayAttribute}
 
     def get(self, id: Union[str, int], lazy: bool = False, **kwargs: Any) -> Group:
         return cast(Group, super().get(id=id, lazy=lazy, **kwargs))
@@ -374,7 +374,7 @@ class GroupSubgroupManager(ListMixin, RESTManager):
         "with_custom_attributes",
         "min_access_level",
     )
-    _types = {"skip_groups": types.ListAttribute}
+    _types = {"skip_groups": types.ArrayAttribute}
 
 
 class GroupDescendantGroup(RESTObject):