summaryrefslogtreecommitdiff
path: root/gitlab/v4/objects/hooks.py
diff options
context:
space:
mode:
authorJohn L. Villalovos <john@sodarock.com>2021-03-07 11:31:23 -0800
committerNejc Habjan <hab.nejc@gmail.com>2021-04-17 17:09:41 +0200
commitaee1f496c1f414c1e30909767d53ae624fe875e7 (patch)
tree04a7fe9d8f77cffeae733bb8dd3447911995f3a1 /gitlab/v4/objects/hooks.py
parent8603248f73d8c751023fbfd2a394c5b7d939af7f (diff)
downloadgitlab-aee1f496c1f414c1e30909767d53ae624fe875e7.tar.gz
chore: have _create_attrs & _update_attrs be a namedtuple
Convert _create_attrs and _update_attrs to use a NamedTuple (RequiredOptional) to help with code readability. Update all code to use the NamedTuple.
Diffstat (limited to 'gitlab/v4/objects/hooks.py')
-rw-r--r--gitlab/v4/objects/hooks.py16
1 files changed, 8 insertions, 8 deletions
diff --git a/gitlab/v4/objects/hooks.py b/gitlab/v4/objects/hooks.py
index 85acf4e..b0eab07 100644
--- a/gitlab/v4/objects/hooks.py
+++ b/gitlab/v4/objects/hooks.py
@@ -1,4 +1,4 @@
-from gitlab.base import RESTManager, RESTObject
+from gitlab.base import RequiredOptional, RESTManager, RESTObject
from gitlab.mixins import CRUDMixin, NoUpdateMixin, ObjectDeleteMixin, SaveMixin
@@ -18,7 +18,7 @@ class Hook(ObjectDeleteMixin, RESTObject):
class HookManager(NoUpdateMixin, RESTManager):
_path = "/hooks"
_obj_cls = Hook
- _create_attrs = (("url",), tuple())
+ _create_attrs = RequiredOptional(required=("url",))
class ProjectHook(SaveMixin, ObjectDeleteMixin, RESTObject):
@@ -29,9 +29,9 @@ class ProjectHookManager(CRUDMixin, RESTManager):
_path = "/projects/%(project_id)s/hooks"
_obj_cls = ProjectHook
_from_parent_attrs = {"project_id": "id"}
- _create_attrs = (
- ("url",),
- (
+ _create_attrs = RequiredOptional(
+ required=("url",),
+ optional=(
"push_events",
"issues_events",
"confidential_issues_events",
@@ -45,9 +45,9 @@ class ProjectHookManager(CRUDMixin, RESTManager):
"token",
),
)
- _update_attrs = (
- ("url",),
- (
+ _update_attrs = RequiredOptional(
+ required=("url",),
+ optional=(
"push_events",
"issues_events",
"confidential_issues_events",