diff options
| author | John L. Villalovos <john@sodarock.com> | 2022-01-09 00:53:12 -0800 |
|---|---|---|
| committer | John L. Villalovos <john@sodarock.com> | 2022-01-09 00:53:12 -0800 |
| commit | 99e1f8bad3e52ca6fb2dc6b876a262c6fee39e41 (patch) | |
| tree | 6a11bdaf3e49a3dec844255d74a860798e8acc68 /gitlab/v4/objects/snippets.py | |
| parent | ac812727c26c9bde4ee5c1115029f2ff4ab1964b (diff) | |
| download | gitlab-jlvillal/encoded_id_alt.tar.gz | |
fix: use url-encoded ID in all paths ALTERNATE METHODjlvillal/encoded_id_alt
An alternative to https://github.com/python-gitlab/python-gitlab/pull/1819
Make sure all usage of the ID in the URL path is encoded. Normally it
isn't an issue as most IDs are integers or strings which don't contain
a slash ('/'). But when the ID is a string with a slash character it
will break things.
Add a test case that shows this fixes wikis issue with subpages which
use the slash character.
Closes: #1079
Diffstat (limited to 'gitlab/v4/objects/snippets.py')
| -rw-r--r-- | gitlab/v4/objects/snippets.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gitlab/v4/objects/snippets.py b/gitlab/v4/objects/snippets.py index 66459c0..9d9dcc4 100644 --- a/gitlab/v4/objects/snippets.py +++ b/gitlab/v4/objects/snippets.py @@ -50,7 +50,7 @@ class Snippet(UserAgentDetailMixin, SaveMixin, ObjectDeleteMixin, RESTObject): Returns: The snippet content """ - path = f"/snippets/{self.get_id()}/raw" + path = f"/snippets/{self.encoded_id}/raw" result = self.manager.gitlab.http_get( path, streamed=streamed, raw=True, **kwargs ) @@ -124,7 +124,7 @@ class ProjectSnippet(UserAgentDetailMixin, SaveMixin, ObjectDeleteMixin, RESTObj Returns: The snippet content """ - path = f"{self.manager.path}/{self.get_id()}/raw" + path = f"{self.manager.path}/{self.encoded_id}/raw" result = self.manager.gitlab.http_get( path, streamed=streamed, raw=True, **kwargs ) |