Merge pull request #1397 from JohnVillalovos/jlvillal/flake8

Fix all issues reported by running: tox -e pep8 and enable pep8 as a linter check

17 files changed, 84 insertions, 88 deletions

diff --git a/gitlab/v4/objects/commits.py b/gitlab/v4/objects/commits.py
index bb81407..037a90d 100644
--- a/gitlab/v4/objects/commits.py
+++ b/gitlab/v4/objects/commits.py
@@ -2,7 +2,7 @@ from gitlab import cli
 from gitlab import exceptions as exc
 from gitlab.base import RequiredOptional, RESTManager, RESTObject
 from gitlab.mixins import CreateMixin, ListMixin, RefreshMixin, RetrieveMixin
-from .discussions import ProjectCommitDiscussionManager
+from .discussions import ProjectCommitDiscussionManager  # noqa: F401
 
 
 __all__ = [
diff --git a/gitlab/v4/objects/discussions.py b/gitlab/v4/objects/discussions.py
index 3477158..2209185 100644
--- a/gitlab/v4/objects/discussions.py
+++ b/gitlab/v4/objects/discussions.py
@@ -1,6 +1,6 @@
 from gitlab.base import RequiredOptional, RESTManager, RESTObject
 from gitlab.mixins import CreateMixin, RetrieveMixin, SaveMixin, UpdateMixin
-from .notes import (
+from .notes import (  # noqa: F401
     ProjectCommitDiscussionNoteManager,
     ProjectIssueDiscussionNoteManager,
     ProjectMergeRequestDiscussionNoteManager,
diff --git a/gitlab/v4/objects/epics.py b/gitlab/v4/objects/epics.py
index 600378d..023d0a6 100644
--- a/gitlab/v4/objects/epics.py
+++ b/gitlab/v4/objects/epics.py
@@ -10,7 +10,7 @@ from gitlab.mixins import (
     SaveMixin,
     UpdateMixin,
 )
-from .events import GroupEpicResourceLabelEventManager
+from .events import GroupEpicResourceLabelEventManager  # noqa: F401
 
 
 __all__ = [
diff --git a/gitlab/v4/objects/events.py b/gitlab/v4/objects/events.py
index bb76b81..f57d02e 100644
--- a/gitlab/v4/objects/events.py
+++ b/gitlab/v4/objects/events.py
@@ -1,4 +1,3 @@
-from gitlab import exceptions as exc
 from gitlab.base import RESTManager, RESTObject
 from gitlab.mixins import ListMixin, RetrieveMixin
 
diff --git a/gitlab/v4/objects/groups.py b/gitlab/v4/objects/groups.py
index 588c506..bc83889 100644
--- a/gitlab/v4/objects/groups.py
+++ b/gitlab/v4/objects/groups.py
@@ -2,25 +2,25 @@ from gitlab import cli, types
 from gitlab import exceptions as exc
 from gitlab.base import RequiredOptional, RESTManager, RESTObject
 from gitlab.mixins import CRUDMixin, ListMixin, ObjectDeleteMixin, SaveMixin
-from .access_requests import GroupAccessRequestManager
-from .audit_events import GroupAuditEventManager
-from .badges import GroupBadgeManager
-from .boards import GroupBoardManager
-from .custom_attributes import GroupCustomAttributeManager
-from .export_import import GroupExportManager, GroupImportManager
-from .epics import GroupEpicManager
-from .issues import GroupIssueManager
-from .labels import GroupLabelManager
-from .members import GroupMemberManager
-from .merge_requests import GroupMergeRequestManager
-from .milestones import GroupMilestoneManager
-from .notification_settings import GroupNotificationSettingsManager
-from .packages import GroupPackageManager
-from .projects import GroupProjectManager
-from .runners import GroupRunnerManager
-from .variables import GroupVariableManager
-from .clusters import GroupClusterManager
-from .deploy_tokens import GroupDeployTokenManager
+from .access_requests import GroupAccessRequestManager  # noqa: F401
+from .audit_events import GroupAuditEventManager  # noqa: F401
+from .badges import GroupBadgeManager  # noqa: F401
+from .boards import GroupBoardManager  # noqa: F401
+from .custom_attributes import GroupCustomAttributeManager  # noqa: F401
+from .export_import import GroupExportManager, GroupImportManager  # noqa: F401
+from .epics import GroupEpicManager  # noqa: F401
+from .issues import GroupIssueManager  # noqa: F401
+from .labels import GroupLabelManager  # noqa: F401
+from .members import GroupMemberManager  # noqa: F401
+from .merge_requests import GroupMergeRequestManager  # noqa: F401
+from .milestones import GroupMilestoneManager  # noqa: F401
+from .notification_settings import GroupNotificationSettingsManager  # noqa: F401
+from .packages import GroupPackageManager  # noqa: F401
+from .projects import GroupProjectManager  # noqa: F401
+from .runners import GroupRunnerManager  # noqa: F401
+from .variables import GroupVariableManager  # noqa: F401
+from .clusters import GroupClusterManager  # noqa: F401
+from .deploy_tokens import GroupDeployTokenManager  # noqa: F401
 
 
 __all__ = [
diff --git a/gitlab/v4/objects/issues.py b/gitlab/v4/objects/issues.py
index 9d38d72..cdaeaba 100644
--- a/gitlab/v4/objects/issues.py
+++ b/gitlab/v4/objects/issues.py
@@ -15,14 +15,14 @@ from gitlab.mixins import (
     TodoMixin,
     UserAgentDetailMixin,
 )
-from .award_emojis import ProjectIssueAwardEmojiManager
-from .discussions import ProjectIssueDiscussionManager
-from .events import (
+from .award_emojis import ProjectIssueAwardEmojiManager  # noqa: F401
+from .discussions import ProjectIssueDiscussionManager  # noqa: F401
+from .events import (  # noqa: F401
     ProjectIssueResourceLabelEventManager,
     ProjectIssueResourceMilestoneEventManager,
     ProjectIssueResourceStateEventManager,
 )
-from .notes import ProjectIssueNoteManager
+from .notes import ProjectIssueNoteManager  # noqa: F401
 
 
 __all__ = [
diff --git a/gitlab/v4/objects/merge_requests.py b/gitlab/v4/objects/merge_requests.py
index 83e8f44..6c166b8 100644
--- a/gitlab/v4/objects/merge_requests.py
+++ b/gitlab/v4/objects/merge_requests.py
@@ -14,14 +14,14 @@ from gitlab.mixins import (
 )
 from .commits import ProjectCommit, ProjectCommitManager
 from .issues import ProjectIssue, ProjectIssueManager
-from .merge_request_approvals import (
+from .merge_request_approvals import (  # noqa: F401
     ProjectMergeRequestApprovalManager,
     ProjectMergeRequestApprovalRuleManager,
 )
-from .award_emojis import ProjectMergeRequestAwardEmojiManager
-from .discussions import ProjectMergeRequestDiscussionManager
-from .notes import ProjectMergeRequestNoteManager
-from .events import (
+from .award_emojis import ProjectMergeRequestAwardEmojiManager  # noqa: F401
+from .discussions import ProjectMergeRequestDiscussionManager  # noqa: F401
+from .notes import ProjectMergeRequestNoteManager  # noqa: F401
+from .events import (  # noqa: F401
     ProjectMergeRequestResourceLabelEventManager,
     ProjectMergeRequestResourceMilestoneEventManager,
     ProjectMergeRequestResourceStateEventManager,
diff --git a/gitlab/v4/objects/milestones.py b/gitlab/v4/objects/milestones.py
index 748f0c6..463fbf6 100644
--- a/gitlab/v4/objects/milestones.py
+++ b/gitlab/v4/objects/milestones.py
@@ -7,7 +7,6 @@ from .merge_requests import (
     ProjectMergeRequest,
     ProjectMergeRequestManager,
     GroupMergeRequest,
-    GroupMergeRequestManager,
 )
 
 
diff --git a/gitlab/v4/objects/notes.py b/gitlab/v4/objects/notes.py
index 362f901..6fa50b9 100644
--- a/gitlab/v4/objects/notes.py
+++ b/gitlab/v4/objects/notes.py
@@ -1,5 +1,3 @@
-from gitlab import cli
-from gitlab import exceptions as exc
 from gitlab.base import RequiredOptional, RESTManager, RESTObject
 from gitlab.mixins import (
     CRUDMixin,
@@ -11,7 +9,7 @@ from gitlab.mixins import (
     SaveMixin,
     UpdateMixin,
 )
-from .award_emojis import (
+from .award_emojis import (  # noqa: F401
     ProjectIssueNoteAwardEmojiManager,
     ProjectMergeRequestNoteAwardEmojiManager,
     ProjectSnippetNoteAwardEmojiManager,
diff --git a/gitlab/v4/objects/pipelines.py b/gitlab/v4/objects/pipelines.py
index 703d40b..bafab9b 100644
--- a/gitlab/v4/objects/pipelines.py
+++ b/gitlab/v4/objects/pipelines.py
@@ -1,4 +1,4 @@
-from gitlab import cli, types
+from gitlab import cli
 from gitlab import exceptions as exc
 from gitlab.base import RequiredOptional, RESTManager, RESTObject
 from gitlab.mixins import (
diff --git a/gitlab/v4/objects/projects.py b/gitlab/v4/objects/projects.py
index c78c8c9..3dba95d 100644
--- a/gitlab/v4/objects/projects.py
+++ b/gitlab/v4/objects/projects.py
@@ -11,55 +11,58 @@ from gitlab.mixins import (
     UpdateMixin,
 )
 
-from .project_access_tokens import ProjectAccessTokenManager
-from .access_requests import ProjectAccessRequestManager
-from .badges import ProjectBadgeManager
-from .boards import ProjectBoardManager
-from .branches import ProjectBranchManager, ProjectProtectedBranchManager
-from .clusters import ProjectClusterManager
-from .commits import ProjectCommitManager
-from .container_registry import ProjectRegistryRepositoryManager
-from .custom_attributes import ProjectCustomAttributeManager
-from .deploy_keys import ProjectKeyManager
-from .deploy_tokens import ProjectDeployTokenManager
-from .deployments import ProjectDeploymentManager
-from .environments import ProjectEnvironmentManager
-from .events import ProjectEventManager
-from .audit_events import ProjectAuditEventManager
-from .export_import import ProjectExportManager, ProjectImportManager
-from .files import ProjectFileManager
-from .hooks import ProjectHookManager
-from .issues import ProjectIssueManager
-from .jobs import ProjectJobManager
-from .labels import ProjectLabelManager
-from .members import ProjectMemberManager
-from .merge_request_approvals import ProjectApprovalManager, ProjectApprovalRuleManager
-from .merge_requests import ProjectMergeRequestManager
-from .milestones import ProjectMilestoneManager
-from .notes import ProjectNoteManager
-from .notification_settings import ProjectNotificationSettingsManager
-from .packages import ProjectPackageManager
-from .pages import ProjectPagesDomainManager
-from .pipelines import (
+from .project_access_tokens import ProjectAccessTokenManager  # noqa: F401
+from .access_requests import ProjectAccessRequestManager  # noqa: F401
+from .badges import ProjectBadgeManager  # noqa: F401
+from .boards import ProjectBoardManager  # noqa: F401
+from .branches import ProjectBranchManager, ProjectProtectedBranchManager  # noqa: F401
+from .clusters import ProjectClusterManager  # noqa: F401
+from .commits import ProjectCommitManager  # noqa: F401
+from .container_registry import ProjectRegistryRepositoryManager  # noqa: F401
+from .custom_attributes import ProjectCustomAttributeManager  # noqa: F401
+from .deploy_keys import ProjectKeyManager  # noqa: F401
+from .deploy_tokens import ProjectDeployTokenManager  # noqa: F401
+from .deployments import ProjectDeploymentManager  # noqa: F401
+from .environments import ProjectEnvironmentManager  # noqa: F401
+from .events import ProjectEventManager  # noqa: F401
+from .audit_events import ProjectAuditEventManager  # noqa: F401
+from .export_import import ProjectExportManager, ProjectImportManager  # noqa: F401
+from .files import ProjectFileManager  # noqa: F401
+from .hooks import ProjectHookManager  # noqa: F401
+from .issues import ProjectIssueManager  # noqa: F401
+from .jobs import ProjectJobManager  # noqa: F401
+from .labels import ProjectLabelManager  # noqa: F401
+from .members import ProjectMemberManager  # noqa: F401
+from .merge_request_approvals import (  # noqa: F401
+    ProjectApprovalManager,
+    ProjectApprovalRuleManager,
+)
+from .merge_requests import ProjectMergeRequestManager  # noqa: F401
+from .milestones import ProjectMilestoneManager  # noqa: F401
+from .notes import ProjectNoteManager  # noqa: F401
+from .notification_settings import ProjectNotificationSettingsManager  # noqa: F401
+from .packages import ProjectPackageManager  # noqa: F401
+from .pages import ProjectPagesDomainManager  # noqa: F401
+from .pipelines import (  # noqa: F401
     ProjectPipeline,
     ProjectPipelineManager,
     ProjectPipelineScheduleManager,
 )
-from .push_rules import ProjectPushRulesManager
-from .releases import ProjectReleaseManager
+from .push_rules import ProjectPushRulesManager  # noqa: F401
+from .releases import ProjectReleaseManager  # noqa: F401
 from .repositories import RepositoryMixin
-from .runners import ProjectRunnerManager
-from .services import ProjectServiceManager
-from .snippets import ProjectSnippetManager
-from .statistics import (
+from .runners import ProjectRunnerManager  # noqa: F401
+from .services import ProjectServiceManager  # noqa: F401
+from .snippets import ProjectSnippetManager  # noqa: F401
+from .statistics import (  # noqa: F401
     ProjectAdditionalStatisticsManager,
     ProjectIssuesStatisticsManager,
 )
-from .tags import ProjectProtectedTagManager, ProjectTagManager
-from .triggers import ProjectTriggerManager
-from .users import ProjectUserManager
-from .variables import ProjectVariableManager
-from .wikis import ProjectWikiManager
+from .tags import ProjectProtectedTagManager, ProjectTagManager  # noqa: F401
+from .triggers import ProjectTriggerManager  # noqa: F401
+from .users import ProjectUserManager  # noqa: F401
+from .variables import ProjectVariableManager  # noqa: F401
+from .wikis import ProjectWikiManager  # noqa: F401
 
 
 __all__ = [
diff --git a/gitlab/v4/objects/releases.py b/gitlab/v4/objects/releases.py
index 2c549b1..ea74adb 100644
--- a/gitlab/v4/objects/releases.py
+++ b/gitlab/v4/objects/releases.py
@@ -1,5 +1,3 @@
-from gitlab import cli
-from gitlab import exceptions as exc
 from gitlab.base import RequiredOptional, RESTManager, RESTObject
 from gitlab.mixins import CRUDMixin, NoUpdateMixin, ObjectDeleteMixin, SaveMixin
 
diff --git a/gitlab/v4/objects/repositories.py b/gitlab/v4/objects/repositories.py
index 6a04174..a171ffb 100644
--- a/gitlab/v4/objects/repositories.py
+++ b/gitlab/v4/objects/repositories.py
@@ -4,7 +4,7 @@ GitLab API: https://docs.gitlab.com/ee/api/repositories.html
 Currently this module only contains repository-related methods for projects.
 """
 
-from gitlab import cli, types, utils
+from gitlab import cli, utils
 from gitlab import exceptions as exc
 
 
diff --git a/gitlab/v4/objects/services.py b/gitlab/v4/objects/services.py
index c638336..17bf63a 100644
--- a/gitlab/v4/objects/services.py
+++ b/gitlab/v4/objects/services.py
@@ -1,5 +1,4 @@
 from gitlab import cli
-from gitlab import exceptions as exc
 from gitlab.base import RESTManager, RESTObject
 from gitlab.mixins import (
     DeleteMixin,
diff --git a/gitlab/v4/objects/snippets.py b/gitlab/v4/objects/snippets.py
index 6159442..330cc8c 100644
--- a/gitlab/v4/objects/snippets.py
+++ b/gitlab/v4/objects/snippets.py
@@ -3,9 +3,9 @@ from gitlab import exceptions as exc
 from gitlab.base import RequiredOptional, RESTManager, RESTObject
 from gitlab.mixins import CRUDMixin, ObjectDeleteMixin, SaveMixin, UserAgentDetailMixin
 
-from .award_emojis import ProjectSnippetAwardEmojiManager
-from .discussions import ProjectSnippetDiscussionManager
-from .notes import ProjectSnippetNoteManager, ProjectSnippetDiscussionNoteManager
+from .award_emojis import ProjectSnippetAwardEmojiManager  # noqa: F401
+from .discussions import ProjectSnippetDiscussionManager  # noqa: F401
+from .notes import ProjectSnippetNoteManager  # noqa: F401
 
 
 __all__ = [
diff --git a/gitlab/v4/objects/todos.py b/gitlab/v4/objects/todos.py
index 33ad7ee..7dc7a51 100644
--- a/gitlab/v4/objects/todos.py
+++ b/gitlab/v4/objects/todos.py
@@ -48,4 +48,4 @@ class TodoManager(ListMixin, DeleteMixin, RESTManager):
         Returns:
             int: The number of todos maked done
         """
-        result = self.gitlab.http_post("/todos/mark_as_done", **kwargs)
+        self.gitlab.http_post("/todos/mark_as_done", **kwargs)
diff --git a/gitlab/v4/objects/users.py b/gitlab/v4/objects/users.py
index 940cf07..c90a7c9 100644
--- a/gitlab/v4/objects/users.py
+++ b/gitlab/v4/objects/users.py
@@ -14,8 +14,8 @@ from gitlab.mixins import (
     UpdateMixin,
 )
 
-from .custom_attributes import UserCustomAttributeManager
-from .events import UserEventManager
+from .custom_attributes import UserCustomAttributeManager  # noqa: F401
+from .events import UserEventManager  # noqa: F401
 
 
 __all__ = [