summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* test(cli): add more real class scenariosfix/parse-cli-objects-camelcaseNejc Habjan2021-03-071-0/+6
|
* fix(cli): fix parsing CLI objects to classnamesNejc Habjan2021-03-073-18/+49
|
* Merge pull request #1336 from em-/fix/quote-everythingNejc Habjan2021-03-072-3/+11
|\ | | | | fix: handle tags like debian/2%2.6-21 as identifiers
| * fix: handle tags like debian/2%2.6-21 as identifiersEmanuele Aina2021-03-052-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Git refnames are relatively free-form and can contain all sort for special characters, not just `/` and `#`, see http://git-scm.com/docs/git-check-ref-format In particular, Debian's DEP-14 standard for storing packaging in git repositories mandates the use of the `%` character in tags in some cases like `debian/2%2.6-21`. Unfortunately python-gitlab currently only escapes `/` to `%2F` and in some cases `#` to `%23`. This means that when using the commit API to retrieve information about the `debian/2%2.6-21` tag only the slash is escaped before being inserted in the URL path and the `%` is left untouched, resulting in something like `/api/v4/projects/123/repository/commits/debian%2F2%2.6-21`. When urllib3 seees that it detects the invalid `%` escape and then urlencodes the whole string, resulting in `/api/v4/projects/123/repository/commits/debian%252F2%252.6-21`, where the original `/` got escaped twice and produced `%252F`. To avoid the issue, fully urlencode identifiers and parameters to avoid the urllib3 auto-escaping in all cases. Signed-off-by: Emanuele Aina <emanuele.aina@collabora.com>
* | Merge pull request #1344 from JohnVillalovos/jlvillal/mixinsNejc Habjan2021-03-061-57/+313
|\ \ | | | | | | chore: add type-hints for gitlab/mixins.py
| * | chore: add type-hints for gitlab/mixins.pyJohn L. Villalovos2021-03-061-57/+313
|/ / | | | | | | | | | | | | * Added type-hints for gitlab/mixins.py * Changed use of filter with a lambda expression to list-comprehension. mypy was not able to understand the previous code. Also list-comprehension is better :)
* | Merge pull request #1353 from JohnVillalovos/jlvillal/mypy_baseNejc Habjan2021-03-061-0/+5
|\ \ | | | | | | chore: add type hints to gitlab/base.py:RESTManager
| * | chore: add type hints to gitlab/base.py:RESTManagerJohn L. Villalovos2021-03-011-0/+5
| | | | | | | | | | | | Add some additional type hints to gitlab/base.py
* | | Merge pull request #1350 from JohnVillalovos/jlvillal/isinstanceNejc Habjan2021-03-061-8/+15
|\ \ \ | | | | | | | | chore: Put assert statements inside 'if TYPE_CHECKING:'
| * | | chore: put assert statements inside 'if TYPE_CHECKING:'John L. Villalovos2021-03-021-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To be safe that we don't assert while running, put the assert statements, which are used by mypy to check that types are correct, inside an 'if TYPE_CHECKING:' block. Also, instead of asserting that the item is a dict, instead assert that it is not a requests.Response object. Theoretically the JSON could return as a list or dict, though at this time we are assuming a dict.
* | | | Merge pull request #1361 from python-gitlab/renovate/sphinx-3.xNejc Habjan2021-03-061-1/+1
|\ \ \ \ | |_|_|/ |/| | | chore(deps): update dependency sphinx to v3.5.2
| * | | chore(deps): update dependency sphinx to v3.5.2Renovate Bot2021-03-061-1/+1
|/ / /
* | | Merge pull request #1358 from ↵Max Wittig2021-03-041-1/+1
|\ \ \ | |_|/ |/| | | | | | | | python-gitlab/renovate/docker-gitlab-gitlab-ce-13.x chore(deps): update gitlab/gitlab-ce docker tag to v13.9.2-ce.0
| * | chore(deps): update gitlab/gitlab-ce docker tag to v13.9.2-ce.0Renovate Bot2021-03-041-1/+1
|/ /
* | Merge pull request #1351 from JohnVillalovos/jlvillal/import_startNejc Habjan2021-03-011-2/+2
|\ \ | |/ |/| chore: del 'import *' in gitlab/v4/objects/project_access_tokens.py
| * chore: del 'import *' in gitlab/v4/objects/project_access_tokens.pyJohn L. Villalovos2021-03-011-2/+2
|/ | | | | Remove usage of 'import *' in gitlab/v4/objects/project_access_tokens.py.
* Merge pull request #1342 from JohnVillalovos/jlvillal/mypy_incompleteNejc Habjan2021-02-285-31/+45
|\ | | | | chore: disallow incomplete type defs
| * chore: disallow incomplete type defsJohn L. Villalovos2021-02-285-31/+45
|/ | | | | | | | | | Don't allow a partially annotated function definition. Either none of the function is annotated or all of it must be. Update code to ensure no-more partially annotated functions. Update gitlab/cli.py with better type-hints. Changed Tuple[Any, ...] to Tuple[str, ...]
* Merge pull request #1347 from python-gitlab/chore/split-repository-methodsMax Wittig2021-02-282-197/+208
|\ | | | | chore(api): move repository endpoints into separate module
| * chore(api): move repository endpoints into separate modulechore/split-repository-methodsNejc Habjan2021-02-282-197/+208
| |
* | Merge pull request #1343 from JohnVillalovos/jlvillal/mypy_testing_thingsNejc Habjan2021-02-281-4/+6
|\ \ | | | | | | chore: add and fix some type-hints in gitlab/client.py
| * | chore: add and fix some type-hints in gitlab/client.pyJohn L. Villalovos2021-02-271-4/+6
| | | | | | | | | | | | Was able to figure out better type-hints for gitlab/client.py
* | | Merge pull request #1345 from JohnVillalovos/jlvillal/mypy_base_fixesNejc Habjan2021-02-281-1/+7
|\ \ \ | |_|/ |/| | chore: add additional type-hints for gitlab/base.py
| * | chore: add additional type-hints for gitlab/base.pyJohn L. Villalovos2021-02-271-1/+7
| |/ | | | | | | | | | | | | Add type-hints for the variables which are set via self.__dict__ mypy doesn't see them when they are assigned via self.__dict__. So declare them in the class definition.
* | Merge pull request #1333 from python-gitlab/feat/user-follow-apiNejc Habjan2021-02-284-0/+152
|\ \ | |/ |/| feat(users): add follow/unfollow API
| * feat(users): add follow/unfollow APIfeat/user-follow-apiMax Wittig2021-02-274-0/+152
| |
* | Merge pull request #1339 from JohnVillalovos/jlvillal/mypy_client_pyMax Wittig2021-02-272-79/+141
|\ \ | | | | | | chore: add type-hints to gitlab/client.py
| * | chore: add type-hints to gitlab/client.pyJohn L. Villalovos2021-02-262-79/+141
| | | | | | | | | | | | Adding some initial type-hints to gitlab/client.py
* | | Merge pull request #1341 from JohnVillalovos/jlvillal/gitterNejc Habjan2021-02-271-0/+5
|\ \ \ | | | | | | | | doc: add information about the gitter community
| * | | docs: add information about the gitter communityJohn L. Villalovos2021-02-261-0/+5
|/ / / | | | | | | | | | | | | Add a section in the README.rst about the gitter community. The badge already exists and is useful but very easy to miss.
* | | Merge pull request #1340 from JohnVillalovos/jlvillal/gitlab_initMax Wittig2021-02-261-1/+0
|\ \ \ | | | | | | | | chore: remove import of gitlab.utils from __init__.py
| * | | chore: remove import of gitlab.utils from __init__.pyJohn L. Villalovos2021-02-261-1/+0
|/ / / | | | | | | | | | | | | | | | | | | | | | Initially when extracting out the gitlab/client.py code we tried to remove this but functional tests failed. Later we fixed the functional test that was failing, so now remove the unneeded import.
* | | Merge pull request #1338 from JohnVillalovos/jlvillal/mypy_baseNejc Habjan2021-02-261-3/+5
|\ \ \ | |/ / |/| | Improve type-hints for gitlab/base.py
| * | chore: improve type-hints for gitlab/base.pyJohn L. Villalovos2021-02-261-3/+5
|/ / | | | | | | Determined the base class for obj_cls and adding type-hints for it.
* | Merge pull request #1334 from JohnVillalovos/jlvillal/mypy_cliNejc Habjan2021-02-261-8/+11
|\ \ | | | | | | chore: add type-hints to gitlab/cli.py
| * | chore: add type-hints to gitlab/cli.pyJohn L. Villalovos2021-02-251-8/+11
| | |
* | | Merge pull request #1337 from python-gitlab/renovate/docker-compose-1.xMax Wittig2021-02-261-1/+1
|\ \ \ | | | | | | | | chore(deps): update dependency docker-compose to v1.28.5
| * | | chore(deps): update dependency docker-compose to v1.28.5Renovate Bot2021-02-261-1/+1
|/ / /
* | | Merge pull request #1335 from JohnVillalovos/jlvillal/remove_dup_classesNejc Habjan2021-02-261-12/+0
|\ \ \ | |/ / |/| | fix: remove duplicate class definitions in v4/objects/users.py
| * | fix: remove duplicate class definitions in v4/objects/users.pyJohn L. Villalovos2021-02-251-12/+0
|/ / | | | | | | | | The classes UserStatus and UserStatusManager were each declared twice. Remove the duplicate declarations.
* | Merge pull request #1328 from ↵Max Wittig2021-02-251-1/+1
|\ \ | | | | | | | | | | | | python-gitlab/renovate/wagoid-commitlint-github-action-3.x chore(deps): update wagoid/commitlint-github-action action to v3
| * | chore(deps): update wagoid/commitlint-github-action action to v3Renovate Bot2021-02-241-1/+1
| |/
* | Merge pull request #1329 from JohnVillalovos/jlvillal/mypy_constMax Wittig2021-02-251-30/+30
|\ \ | | | | | | Add type-hints to gitlab/const.py
| * | chore: add type-hints to gitlab/const.pyJohn L. Villalovos2021-02-251-30/+30
| | |
* | | Merge pull request #1330 from JohnVillalovos/jlvillal/mypy_utilsMax Wittig2021-02-251-6/+14
|\ \ \ | | | | | | | | chore: add type hints to gitlab/utils.py
| * | | chore: add type hints to gitlab/utils.pyJohn L. Villalovos2021-02-251-6/+14
| |/ /
* | | Merge pull request #1331 from JohnVillalovos/jlvillal/mypy_configMax Wittig2021-02-251-4/+7
|\ \ \ | | | | | | | | chore: add type-hints to gitlab/config.py
| * | | chore: add type-hints to gitlab/config.pyJohn L. Villalovos2021-02-251-4/+7
| |/ /
* | | Merge pull request #1332 from JohnVillalovos/jlvillal/fix_variableNejc Habjan2021-02-251-1/+1
|\ \ \ | |/ / |/| | chore: fix wrong variable name in cli.py
| * | fix: wrong variable nameJohn L. Villalovos2021-02-251-1/+1
|/ / | | | | | | | | Discovered this when I ran flake8 on the file. Unfortunately I was the one who introduced this wrong variable name :(
View Lorry Controller Status