From 83670a49a3affd2465f8fcbcc3c26141592c1ccd Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Sat, 17 Apr 2021 14:06:36 -0700 Subject: chore: fix E712 errors reported by flake8 E712: Comparison to true should be 'if cond is true:' or 'if cond:' https://www.flake8rules.com/rules/E712.html --- .../tests/objects/test_project_merge_request_approvals.py | 6 +++--- gitlab/tests/objects/test_runners.py | 14 +++++++------- 2 files changed, 10 insertions(+), 10 deletions(-) (limited to 'gitlab/tests/objects') diff --git a/gitlab/tests/objects/test_project_merge_request_approvals.py b/gitlab/tests/objects/test_project_merge_request_approvals.py index a8e31e6..d8ed3a8 100644 --- a/gitlab/tests/objects/test_project_merge_request_approvals.py +++ b/gitlab/tests/objects/test_project_merge_request_approvals.py @@ -241,7 +241,7 @@ def test_project_approval_manager_update_uses_post(project, resp_snippet): assert isinstance( approvals, gitlab.v4.objects.merge_request_approvals.ProjectApprovalManager ) - assert approvals._update_uses_post == True + assert approvals._update_uses_post is True def test_list_merge_request_approval_rules(project, resp_snippet): @@ -257,7 +257,7 @@ def test_update_merge_request_approvals_set_approvers(project, resp_snippet): approvals, gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager, ) - assert approvals._update_uses_post == True + assert approvals._update_uses_post is True response = approvals.set_approvers( updated_approval_rule_approvals_required, approver_ids=updated_approval_rule_user_ids, @@ -277,7 +277,7 @@ def test_create_merge_request_approvals_set_approvers(project, resp_snippet): approvals, gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager, ) - assert approvals._update_uses_post == True + assert approvals._update_uses_post is True response = approvals.set_approvers( new_approval_rule_approvals_required, approver_ids=new_approval_rule_user_ids, diff --git a/gitlab/tests/objects/test_runners.py b/gitlab/tests/objects/test_runners.py index 30fdb41..7185c26 100644 --- a/gitlab/tests/objects/test_runners.py +++ b/gitlab/tests/objects/test_runners.py @@ -200,7 +200,7 @@ def resp_runner_verify(): def test_owned_runners_list(gl: gitlab.Gitlab, resp_get_runners_list): runners = gl.runners.list() - assert runners[0].active == True + assert runners[0].active is True assert runners[0].id == 6 assert runners[0].name == "test-name" assert len(runners) == 1 @@ -208,7 +208,7 @@ def test_owned_runners_list(gl: gitlab.Gitlab, resp_get_runners_list): def test_project_runners_list(gl: gitlab.Gitlab, resp_get_runners_list): runners = gl.projects.get(1, lazy=True).runners.list() - assert runners[0].active == True + assert runners[0].active is True assert runners[0].id == 6 assert runners[0].name == "test-name" assert len(runners) == 1 @@ -216,7 +216,7 @@ def test_project_runners_list(gl: gitlab.Gitlab, resp_get_runners_list): def test_group_runners_list(gl: gitlab.Gitlab, resp_get_runners_list): runners = gl.groups.get(1, lazy=True).runners.list() - assert runners[0].active == True + assert runners[0].active is True assert runners[0].id == 6 assert runners[0].name == "test-name" assert len(runners) == 1 @@ -224,7 +224,7 @@ def test_group_runners_list(gl: gitlab.Gitlab, resp_get_runners_list): def test_all_runners_list(gl: gitlab.Gitlab, resp_get_runners_list): runners = gl.runners.all() - assert runners[0].active == True + assert runners[0].active is True assert runners[0].id == 6 assert runners[0].name == "test-name" assert len(runners) == 1 @@ -238,7 +238,7 @@ def test_create_runner(gl: gitlab.Gitlab, resp_runner_register): def test_get_update_runner(gl: gitlab.Gitlab, resp_runner_detail): runner = gl.runners.get(6) - assert runner.active == True + assert runner.active is True runner.tag_list.append("new") runner.save() @@ -259,14 +259,14 @@ def test_disable_group_runner(gl: gitlab.Gitlab, resp_runner_disable): def test_enable_project_runner(gl: gitlab.Gitlab, resp_runner_enable): runner = gl.projects.get(1, lazy=True).runners.create({"runner_id": 6}) - assert runner.active == True + assert runner.active is True assert runner.id == 6 assert runner.name == "test-name" def test_enable_group_runner(gl: gitlab.Gitlab, resp_runner_enable): runner = gl.groups.get(1, lazy=True).runners.create({"runner_id": 6}) - assert runner.active == True + assert runner.active is True assert runner.id == 6 assert runner.name == "test-name" -- cgit v1.2.1 From ff21eb664871904137e6df18308b6e90290ad490 Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Sat, 17 Apr 2021 14:20:05 -0700 Subject: chore: fix F401 errors reported by flake8 F401: Module imported but unused https://www.flake8rules.com/rules/F401.html --- gitlab/tests/objects/test_bridges.py | 4 +--- gitlab/tests/objects/test_submodules.py | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) (limited to 'gitlab/tests/objects') diff --git a/gitlab/tests/objects/test_bridges.py b/gitlab/tests/objects/test_bridges.py index ea8c634..4d39186 100644 --- a/gitlab/tests/objects/test_bridges.py +++ b/gitlab/tests/objects/test_bridges.py @@ -1,12 +1,10 @@ """ GitLab API: https://docs.gitlab.com/ee/api/jobs.html#list-pipeline-bridges """ -import re - import pytest import responses -from gitlab.v4.objects import Project, ProjectPipelineBridge +from gitlab.v4.objects import ProjectPipelineBridge @pytest.fixture diff --git a/gitlab/tests/objects/test_submodules.py b/gitlab/tests/objects/test_submodules.py index 539af7b..69c1cd7 100644 --- a/gitlab/tests/objects/test_submodules.py +++ b/gitlab/tests/objects/test_submodules.py @@ -4,8 +4,6 @@ GitLab API: https://docs.gitlab.com/ce/api/repository_submodules.html import pytest import responses -from gitlab.v4.objects import Project - @pytest.fixture def resp_update_submodule(): -- cgit v1.2.1 From 40f4ab20ba0903abd3d5c6844fc626eb264b9a6a Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Sat, 17 Apr 2021 14:59:35 -0700 Subject: chore: fix F841 errors reported by flake8 Local variable name is assigned to but never used https://www.flake8rules.com/rules/F841.html --- gitlab/tests/objects/test_appearance.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gitlab/tests/objects') diff --git a/gitlab/tests/objects/test_appearance.py b/gitlab/tests/objects/test_appearance.py index 7c52301..43ea574 100644 --- a/gitlab/tests/objects/test_appearance.py +++ b/gitlab/tests/objects/test_appearance.py @@ -63,4 +63,4 @@ def test_get_update_appearance(gl, resp_application_appearance): def test_update_appearance(gl, resp_application_appearance): - resp = gl.appearance.update(title=new_title, description=new_description) + gl.appearance.update(title=new_title, description=new_description) -- cgit v1.2.1