From a2e7c383e10509b6eb0fa8760727036feb0807c8 Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Mon, 10 Jan 2022 18:11:05 -0800 Subject: chore: add EncodedId string class to use to hold URL-encoded paths Add EncodedId string class. This class returns a URL-encoded string but ensures it will only URL-encode it once even if recursively called. Also added some functional tests of 'lazy' objects to make sure they work. --- gitlab/v4/objects/merge_request_approvals.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gitlab/v4/objects') diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py index 2bbd399..45016d5 100644 --- a/gitlab/v4/objects/merge_request_approvals.py +++ b/gitlab/v4/objects/merge_request_approvals.py @@ -75,7 +75,7 @@ class ProjectApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager): if TYPE_CHECKING: assert self._parent is not None - path = f"/projects/{self._parent.get_id()}/approvers" + path = f"/projects/{self._parent.encoded_id}/approvers" data = {"approver_ids": approver_ids, "approver_group_ids": approver_group_ids} result = self.gitlab.http_put(path, post_data=data, **kwargs) if TYPE_CHECKING: -- cgit v1.2.1