diff options
| author | Sebastian Thiel <byronimo@gmail.com> | 2016-05-26 19:41:00 +0200 |
|---|---|---|
| committer | Sebastian Thiel <byronimo@gmail.com> | 2016-05-26 19:41:00 +0200 |
| commit | 515a6b9ccf87bd1d3f5f2edd229d442706705df5 (patch) | |
| tree | 040331b258b8bbc48514ca4242b3f61553e1c02b /git/cmd.py | |
| parent | 04ff96ddd0215881f72cc532adc6ff044e77ea3e (diff) | |
| download | gitpython-515a6b9ccf87bd1d3f5f2edd229d442706705df5.tar.gz | |
fix(remote): use universal_newlines for fetch/push
That way, real-time parsing of output should finally be possible.
Related to #444
Diffstat (limited to 'git/cmd.py')
| -rw-r--r-- | git/cmd.py | 9 |
1 files changed, 7 insertions, 2 deletions
@@ -44,7 +44,8 @@ from git.compat import ( execute_kwargs = ('istream', 'with_keep_cwd', 'with_extended_output', 'with_exceptions', 'as_process', 'stdout_as_string', - 'output_stream', 'with_stdout', 'kill_after_timeout') + 'output_stream', 'with_stdout', 'kill_after_timeout', + 'universal_newlines') log = logging.getLogger('git.cmd') log.addHandler(logging.NullHandler()) @@ -487,6 +488,7 @@ class Git(LazyMixin): stdout_as_string=True, kill_after_timeout=None, with_stdout=True, + universal_newlines=False, **subprocess_kwargs ): """Handles executing the command on the shell and consumes and returns @@ -541,7 +543,9 @@ class Git(LazyMixin): specify may not be the same ones. :param with_stdout: If True, default True, we open stdout on the created process - + :param universal_newlines: + if True, pipes will be opened as text, and lines are split at + all known line endings. :param kill_after_timeout: To specify a timeout in seconds for the git command, after which the process should be killed. This will have no effect if as_process is set to True. It is @@ -608,6 +612,7 @@ class Git(LazyMixin): stdout=with_stdout and PIPE or open(os.devnull, 'wb'), shell=self.USE_SHELL, close_fds=(os.name == 'posix'), # unsupported on windows + universal_newlines=universal_newlines, **subprocess_kwargs ) except cmd_not_found_exception as err: |