diff options
author | Tatsuki Sugiura <sugi@nemui.org> | 2012-05-08 09:18:36 +0900 |
---|---|---|
committer | Mateusz Dereniowski <derenio@gmail.com> | 2014-03-31 12:36:21 +0200 |
commit | 56cc93a548f35a0becd49a7eacde86f55ffc5dc5 (patch) | |
tree | afbd06cd9424bd415955330b8409639cf0b7193a /git/cmd.py | |
parent | 56d5d0c70cf3a914286fe016030c9edec25c3ae0 (diff) | |
download | gitpython-56cc93a548f35a0becd49a7eacde86f55ffc5dc5.tar.gz |
Fix fd leak on git cmd.
Currently if command is called with as_proces=True, pipes for the
command will not be closed.
This change makes sure to close command file descriptors.
Conflicts:
git/cmd.py
Diffstat (limited to 'git/cmd.py')
-rw-r--r-- | git/cmd.py | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -73,6 +73,9 @@ class Git(LazyMixin): self.args = args def __del__(self): + self.proc.stdout.close() + self.proc.stderr.close() + # did the process finish already so we have a return code ? if self.proc.poll() is not None: return @@ -100,6 +103,8 @@ class Git(LazyMixin): :raise GitCommandError: if the return status is not 0""" status = self.proc.wait() + self.proc.stdout.close() + self.proc.stderr.close() if status != 0: raise GitCommandError(self.args, status, self.proc.stderr.read()) # END status handling |