diff options
author | Cory Johns <cjohns@slashdotmedia.com> | 2013-10-09 19:02:56 +0000 |
---|---|---|
committer | Cory Johns <cjohns@slashdotmedia.com> | 2013-10-09 20:49:44 +0000 |
commit | d3a728277877924e889e9fef42501127f48a4e77 (patch) | |
tree | 930599537d72c28517b045924433f44ef7eb8da6 /git/remote.py | |
parent | 5869c5c1a51d448a411ae0d51d888793c35db9c0 (diff) | |
download | gitpython-d3a728277877924e889e9fef42501127f48a4e77.tar.gz |
[#5330] Ensure wait() is called on git processes
Diffstat (limited to 'git/remote.py')
-rw-r--r-- | git/remote.py | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/git/remote.py b/git/remote.py index 5e4439fb..e38b3540 100644 --- a/git/remote.py +++ b/git/remote.py @@ -24,7 +24,10 @@ from refs import ( TagReference ) -from git.util import join_path +from git.util import ( + join_path, + finalize_process + ) from gitdb.util import join import re @@ -58,18 +61,6 @@ def digest_process_messages(fh, progress): # END while file is not done reading return dropped_lines -def finalize_process(proc): - """Wait for the process (clone, fetch, pull or push) and handle its errors accordingly""" - try: - proc.wait() - except GitCommandError,e: - # if a push has rejected items, the command has non-zero return status - # a return status of 128 indicates a connection error - reraise the previous one - if proc.poll() == 128: - raise - pass - # END exception handling - def add_progress(kwargs, git, progress): """Add the --progress flag to the given kwargs dict if supported by the git command. If the actual progress in the given progress instance is not |