summaryrefslogtreecommitdiff
path: root/git/repo/base.py
diff options
context:
space:
mode:
authorKostis Anagnostopoulos <ankostis@gmail.com>2016-10-02 14:24:28 +0200
committerKostis Anagnostopoulos <ankostis@gmail.com>2016-10-02 14:30:02 +0200
commitdf5c1cb715664fd7a98160844572cc473cb6b87c (patch)
tree3844da31fa8a15c0b2ab687038911ec0f5a75b61 /git/repo/base.py
parentb3b9c0242ba2893231e0ab1c13fa2a0c8a9cfc59 (diff)
downloadgitpython-df5c1cb715664fd7a98160844572cc473cb6b87c.tar.gz
FIX regression by #519 on reading stdout/stderr of cmds
Diffstat (limited to 'git/repo/base.py')
-rw-r--r--git/repo/base.py8
1 files changed, 6 insertions, 2 deletions
diff --git a/git/repo/base.py b/git/repo/base.py
index 947d77d2..26753bab 100644
--- a/git/repo/base.py
+++ b/git/repo/base.py
@@ -899,8 +899,12 @@ class Repo(object):
try:
proc = git.clone(url, path, with_extended_output=True, as_process=True,
v=True, **add_progress(kwargs, git, progress))
- progress_handler = progress and progress.new_message_handler() or None
- handle_process_output(proc, None, progress_handler, finalize_process)
+ if progress:
+ handle_process_output(proc, None, progress.new_message_handler(), finalize_process)
+ else:
+ (stdout, stderr) = proc.communicate() # FIXME: Will block of outputs are big!
+ finalize_process(proc, stderr=stderr)
+ # end handle progress
finally:
if prev_cwd is not None:
os.chdir(prev_cwd)