diff options
| author | Kostis Anagnostopoulos <ankostis@gmail.com> | 2016-09-26 01:36:57 +0200 |
|---|---|---|
| committer | Kostis Anagnostopoulos <ankostis@gmail.com> | 2016-09-26 13:37:55 +0200 |
| commit | 7ec2f8a4f26cec3fbbe1fb447058acaf508b39c0 (patch) | |
| tree | 2868007d4c4be16ee5e24ca09df6ab2533dea248 /git/test/test_git.py | |
| parent | 082851e0afd3a58790fe3c2434f6d070f97c69c1 (diff) | |
| download | gitpython-7ec2f8a4f26cec3fbbe1fb447058acaf508b39c0.tar.gz | |
apveyor, #519: FIX incomplete Popen pump
+ The code in `_read_lines_from_fno()` was reading the stream only once
per invocation, so when input was larger than `mmap.PAGESIZE`, bytes
were forgotten in the stream.
+ Replaced buffer-building code with iterate-on-file-descriptors.
+ Also set deamon-threads.
Diffstat (limited to 'git/test/test_git.py')
| -rw-r--r-- | git/test/test_git.py | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/git/test/test_git.py b/git/test/test_git.py index 534539d7..82ed2ace 100644 --- a/git/test/test_git.py +++ b/git/test/test_git.py @@ -238,9 +238,11 @@ class TestGit(TestBase): stdin=None, stdout=subprocess.PIPE, stderr=subprocess.PIPE, - shell=False) + shell=False, + creationflags=Git.CREATE_NO_WINDOW if sys.platform == 'win32' else 0, + ) handle_process_output(proc, counter_stdout, counter_stderr, lambda proc: proc.wait()) - assert count[1] == line_count - assert count[2] == line_count + self.assertEqual(count[1], line_count) + self.assertEqual(count[2], line_count) |