diff options
| author | Sebastian Thiel <byronimo@gmail.com> | 2016-05-25 09:42:52 +0200 |
|---|---|---|
| committer | Sebastian Thiel <byronimo@gmail.com> | 2016-05-25 09:57:54 +0200 |
| commit | 6ef273914de9b8a50dd0dd5308e66de85eb7d44a (patch) | |
| tree | 6945642d016535a537263b8222af0e36c1a7d9f7 /git/test | |
| parent | b6a6a109885856aeff374c058db0f92c95606a0b (diff) | |
| download | gitpython-6ef273914de9b8a50dd0dd5308e66de85eb7d44a.tar.gz | |
fix(RemoteProgress): improve message sanitization
Don't allow `, ` prefixes or suffixes in messages.
Fixes #438
Diffstat (limited to 'git/test')
| -rw-r--r-- | git/test/test_remote.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/git/test/test_remote.py b/git/test/test_remote.py index 6c37614d..9ca2f207 100644 --- a/git/test/test_remote.py +++ b/git/test/test_remote.py @@ -62,6 +62,14 @@ class TestRemoteProgress(RemoteProgress): # check each stage only comes once op_id = op_code & self.OP_MASK assert op_id in (self.COUNTING, self.COMPRESSING, self.WRITING) + + if op_code & self.WRITING > 0: + if op_code & self.BEGIN > 0: + assert not message, 'should not have message when remote begins writing' + elif op_code & self.END > 0: + assert message + assert not message.startswith(', '), "Sanitize progress messages: '%s'" % message + assert not message.endswith(', '), "Sanitize progress messages: '%s'" % message self._stages_per_op.setdefault(op_id, 0) self._stages_per_op[op_id] = self._stages_per_op[op_id] | (op_code & self.STAGE_MASK) |