From 32e4e08cf9ccfa90f0bc6d26f0c7007aeafcffeb Mon Sep 17 00:00:00 2001 From: Sebastian Thiel Date: Sun, 31 May 2015 14:48:47 +0200 Subject: fix(git-cmd): use LC_ALL instead of LC_MESSAGES Previously, only program messages where forced to the C-locale, now we force the entire program. That way, we should assure a remote will not provide us with branch information in any other language but english. Related to #290 --- git/cmd.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'git/cmd.py') diff --git a/git/cmd.py b/git/cmd.py index 429046be..ee35bbcf 100644 --- a/git/cmd.py +++ b/git/cmd.py @@ -530,7 +530,7 @@ class Git(LazyMixin): * output_stream if extended_output = False * tuple(int(status), output_stream, str(stderr)) if extended_output = True - Note git is executed with LC_MESSAGES="C" to ensure consitent + Note git is executed with LC_MESSAGES="C" to ensure consistent output regardless of system language. :raise GitCommandError: @@ -549,7 +549,9 @@ class Git(LazyMixin): # Start the process env = os.environ.copy() - env["LC_MESSAGES"] = "C" + # Attempt to force all output to plain ascii english, which is what some parsing code + # may expect. + env["LC_ALL"] = "C" env.update(self._environment) if sys.platform == 'win32': -- cgit v1.2.1