From 5593dc014a41c563ba524b9303e75da46ee96bd5 Mon Sep 17 00:00:00 2001 From: Sebastian Thiel Date: Thu, 5 Nov 2009 18:22:29 +0100 Subject: Fixed windows TASKKILL so it actually does something *silently* --- lib/git/cmd.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'lib/git/cmd.py') diff --git a/lib/git/cmd.py b/lib/git/cmd.py index fb6f2998..ab34fa58 100644 --- a/lib/git/cmd.py +++ b/lib/git/cmd.py @@ -63,7 +63,10 @@ class Git(object): os.kill(self.proc.pid, 2) # interrupt signal except AttributeError: # try windows - subprocess.call(("TASKKILL", "/T", "/PID", self.proc.pid)) + # for some reason, providing None for stdout/stderr still prints something. This is why + # we simply use the shell and redirect to nul. Its slower than CreateProcess, question + # is whether we really want to see all these messages. Its annoying no matter what. + subprocess.call(("TASKKILL /F /T /PID %s > nul" % str(self.proc.pid)), shell=True) # END exception handling def __getattr__(self, attr): -- cgit v1.2.1