From c8c50d8be2dc5ae74e53e44a87f580bf25956af9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steve=20Fr=C3=A9cinaux?= Date: Sat, 6 Sep 2008 00:35:04 +0200 Subject: Do not use **kwargs for constructors. It is better to have an explicit list of variables for the constructors, be it only to avoid mispelled arguments. --- lib/git/tree.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'lib/git/tree.py') diff --git a/lib/git/tree.py b/lib/git/tree.py index 59d3af1e..dbd78ac4 100644 --- a/lib/git/tree.py +++ b/lib/git/tree.py @@ -9,17 +9,14 @@ from lazy import LazyMixin import blob class Tree(LazyMixin): - def __init__(self, repo, **kwargs): + def __init__(self, repo, id, mode=None, name=None): LazyMixin.__init__(self) self.repo = repo - self.id = None - self.mode = None - self.name = None + self.id = id + self.mode = mode + self.name = name self._contents = None - for k, v in kwargs.items(): - setattr(self, k, v) - def __bake__(self): # Ensure the treeish references directly a tree treeish = self.id -- cgit v1.2.1