<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/isort.git, branch develop</title>
<subtitle>github.com: timothycrosley/isort.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/'/>
<entry>
<title>Add - Jon Banafato (@jonafato)</title>
<updated>2021-03-23T06:33:04+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-23T06:33:04+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=a07bdf3cf7484dfb7570b4eec076fc0bc483b79a'/>
<id>a07bdf3cf7484dfb7570b4eec076fc0bc483b79a</id>
<content type='text'>
 to contributors list
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 to contributors list
</pre>
</div>
</content>
</entry>
<entry>
<title>Add changelog entry for fix from @jonafato</title>
<updated>2021-03-23T06:32:07+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-23T06:32:07+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=5d3aa873fef384a03a0b125de92d4362be305960'/>
<id>5d3aa873fef384a03a0b125de92d4362be305960</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1695 from jonafato/fix-multiline-docstring-ending-on-line-add_import</title>
<updated>2021-03-23T06:29:16+00:00</updated>
<author>
<name>Timothy Edmund Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-23T06:29:16+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=f5e04479f2411e3e29d629ee6c57810153167eff'/>
<id>f5e04479f2411e3e29d629ee6c57810153167eff</id>
<content type='text'>
Fix bug regarding multiline docstrings</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix bug regarding multiline docstrings</pre>
</div>
</content>
</entry>
<entry>
<title>Fix bug regarding multiline docstrings</title>
<updated>2021-03-22T17:54:52+00:00</updated>
<author>
<name>Jon Banafato</name>
<email>jon@jonafato.com</email>
</author>
<published>2021-03-22T17:24:15+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=2ccb49776957dbcb8b05ac4cc5eb9ef20a54a25d'/>
<id>2ccb49776957dbcb8b05ac4cc5eb9ef20a54a25d</id>
<content type='text'>
If a multiline docstring has its closing quotes at the end of a line
instead of on a separate line, isort fails to properly add imports using
the `add_imports` config option; instead, it adds the desired imports
into the middle of the docstring as illustrated below. While PEP 257
(and other guides) advises that closing quotes appear on their own line,
`isort` should not fail here.

This change adds a check for closing docstrings at the end of a line in
addition to the existing line start check for all comment indicators. A
new section of the `test_add_imports` test explicitly tests multiline
imports and this failure scenario specifically.

---

A working example:

```python
"""My module.

Provides example functionality.
"""

print("hello, world")
```

Running `isort --add-import "from __future__ import annotations"`
produces the following as expected:

```python
"""My module.

Provides example functionality.
"""

from __future__ import annotations

print("hello, world")
```

---

The failure behavior described:

```python
"""My module.

Provides example functionality."""

print("hello, world")
```

Running `isort --add-import "from __future__ import annotations"` as
above produces the following result:

```python
"""My module.

from __future__ import annotations

Provides example functionality."""

print("hello, world")
```

Subsequent executions add more import lines into the docstring. This
behavior occurs even if the file already has the desired imports.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If a multiline docstring has its closing quotes at the end of a line
instead of on a separate line, isort fails to properly add imports using
the `add_imports` config option; instead, it adds the desired imports
into the middle of the docstring as illustrated below. While PEP 257
(and other guides) advises that closing quotes appear on their own line,
`isort` should not fail here.

This change adds a check for closing docstrings at the end of a line in
addition to the existing line start check for all comment indicators. A
new section of the `test_add_imports` test explicitly tests multiline
imports and this failure scenario specifically.

---

A working example:

```python
"""My module.

Provides example functionality.
"""

print("hello, world")
```

Running `isort --add-import "from __future__ import annotations"`
produces the following as expected:

```python
"""My module.

Provides example functionality.
"""

from __future__ import annotations

print("hello, world")
```

---

The failure behavior described:

```python
"""My module.

Provides example functionality."""

print("hello, world")
```

Running `isort --add-import "from __future__ import annotations"` as
above produces the following result:

```python
"""My module.

from __future__ import annotations

Provides example functionality."""

print("hello, world")
```

Subsequent executions add more import lines into the docstring. This
behavior occurs even if the file already has the desired imports.
</pre>
</div>
</content>
</entry>
<entry>
<title>Update documentation</title>
<updated>2021-03-21T06:08:36+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-21T06:08:36+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=9665722d4c4acf6fa4c95d4e7966793d03f3821d'/>
<id>9665722d4c4acf6fa4c95d4e7966793d03f3821d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add - Christian Clauss (@cclauss) to acknowledgements</title>
<updated>2021-03-21T06:08:02+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-21T06:08:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=faa829351c9589d1a1607e5b8dd0f1a139c68036'/>
<id>faa829351c9589d1a1607e5b8dd0f1a139c68036</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Bump version to 5.8.0</title>
<updated>2021-03-21T05:25:02+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-21T05:25:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=a6222a8a125ec719724e628a5d3d0d5c60923281'/>
<id>a6222a8a125ec719724e628a5d3d0d5c60923281</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1694 from PyCQA/issue/1566</title>
<updated>2021-03-20T07:17:14+00:00</updated>
<author>
<name>Timothy Edmund Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-20T07:17:14+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=43cfa4752acf9a64124aadfcbc11747afd0d9391'/>
<id>43cfa4752acf9a64124aadfcbc11747afd0d9391</id>
<content type='text'>
Issue/1566</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Issue/1566</pre>
</div>
</content>
</entry>
<entry>
<title>Fix issue #1566: Fixed single location parsed line separator isn't used</title>
<updated>2021-03-20T07:06:38+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-20T07:06:38+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=404d809a692d68db0f36016b91171befec48be81'/>
<id>404d809a692d68db0f36016b91171befec48be81</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix test to ensure output is the same</title>
<updated>2021-03-20T07:06:02+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-20T07:06:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=0ee873365c722d5eea95e0e838b771f4b06a61e1'/>
<id>0ee873365c722d5eea95e0e838b771f4b06a61e1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
