<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/python-packages/isort.git/tests, branch develop</title>
<subtitle>github.com: timothycrosley/isort.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/'/>
<entry>
<title>Fix bug regarding multiline docstrings</title>
<updated>2021-03-22T17:54:52+00:00</updated>
<author>
<name>Jon Banafato</name>
<email>jon@jonafato.com</email>
</author>
<published>2021-03-22T17:24:15+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=2ccb49776957dbcb8b05ac4cc5eb9ef20a54a25d'/>
<id>2ccb49776957dbcb8b05ac4cc5eb9ef20a54a25d</id>
<content type='text'>
If a multiline docstring has its closing quotes at the end of a line
instead of on a separate line, isort fails to properly add imports using
the `add_imports` config option; instead, it adds the desired imports
into the middle of the docstring as illustrated below. While PEP 257
(and other guides) advises that closing quotes appear on their own line,
`isort` should not fail here.

This change adds a check for closing docstrings at the end of a line in
addition to the existing line start check for all comment indicators. A
new section of the `test_add_imports` test explicitly tests multiline
imports and this failure scenario specifically.

---

A working example:

```python
"""My module.

Provides example functionality.
"""

print("hello, world")
```

Running `isort --add-import "from __future__ import annotations"`
produces the following as expected:

```python
"""My module.

Provides example functionality.
"""

from __future__ import annotations

print("hello, world")
```

---

The failure behavior described:

```python
"""My module.

Provides example functionality."""

print("hello, world")
```

Running `isort --add-import "from __future__ import annotations"` as
above produces the following result:

```python
"""My module.

from __future__ import annotations

Provides example functionality."""

print("hello, world")
```

Subsequent executions add more import lines into the docstring. This
behavior occurs even if the file already has the desired imports.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If a multiline docstring has its closing quotes at the end of a line
instead of on a separate line, isort fails to properly add imports using
the `add_imports` config option; instead, it adds the desired imports
into the middle of the docstring as illustrated below. While PEP 257
(and other guides) advises that closing quotes appear on their own line,
`isort` should not fail here.

This change adds a check for closing docstrings at the end of a line in
addition to the existing line start check for all comment indicators. A
new section of the `test_add_imports` test explicitly tests multiline
imports and this failure scenario specifically.

---

A working example:

```python
"""My module.

Provides example functionality.
"""

print("hello, world")
```

Running `isort --add-import "from __future__ import annotations"`
produces the following as expected:

```python
"""My module.

Provides example functionality.
"""

from __future__ import annotations

print("hello, world")
```

---

The failure behavior described:

```python
"""My module.

Provides example functionality."""

print("hello, world")
```

Running `isort --add-import "from __future__ import annotations"` as
above produces the following result:

```python
"""My module.

from __future__ import annotations

Provides example functionality."""

print("hello, world")
```

Subsequent executions add more import lines into the docstring. This
behavior occurs even if the file already has the desired imports.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix test to ensure output is the same</title>
<updated>2021-03-20T07:06:02+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-20T07:06:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=0ee873365c722d5eea95e0e838b771f4b06a61e1'/>
<id>0ee873365c722d5eea95e0e838b771f4b06a61e1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Create failing test for issue #1566</title>
<updated>2021-03-20T06:33:56+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-20T06:33:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=a1f2782e4d825a54b2eec698b3520e30526a343f'/>
<id>a1f2782e4d825a54b2eec698b3520e30526a343f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed #1594: incorrect placement of noqa comments with multiple from imports.</title>
<updated>2021-03-19T06:23:02+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-19T06:23:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=5a0ebba5174d67210b6b23f8f644f1b0bc03de73'/>
<id>5a0ebba5174d67210b6b23f8f644f1b0bc03de73</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolved #1504: Added ability to push star imports to the top to avoid overriding explicitly defined imports.</title>
<updated>2021-03-18T05:22:22+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-18T05:22:22+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=33b4cc3abb700cd89a52ef5fd27080bf32c991a4'/>
<id>33b4cc3abb700cd89a52ef5fd27080bf32c991a4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add test case for issue #1645: Allowing sort order to be reversed</title>
<updated>2021-03-17T07:31:46+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-17T07:31:46+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=7802b4f88e92a4a9534b9044527cd1f37c965755'/>
<id>7802b4f88e92a4a9534b9044527cd1f37c965755</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add test case to ensure incorrectly formatted from statements dont disapear</title>
<updated>2021-03-16T06:04:37+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-16T06:04:37+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=2bce0f2c197a6c7b70c7ae2a6c9c0cbded2a6600'/>
<id>2bce0f2c197a6c7b70c7ae2a6c9c0cbded2a6600</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve #1684: Add support for --extend-skip and --extend-skip-glob</title>
<updated>2021-03-14T02:41:15+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-14T02:41:15+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=d09acd0974847314278e18c92db13950555e0ae9'/>
<id>d09acd0974847314278e18c92db13950555e0ae9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'develop' into issue/1659/force-sort-sections-with-relative-imports</title>
<updated>2021-03-11T06:30:25+00:00</updated>
<author>
<name>Timothy Edmund Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-11T06:30:25+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=88006f996a8e3df3aa3bca1f41b0129f964d1261'/>
<id>88006f996a8e3df3aa3bca1f41b0129f964d1261</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Implemented #1638 / #1644: Provide a flag  to ensure same file handle is used after sorting.</title>
<updated>2021-03-05T04:05:19+00:00</updated>
<author>
<name>Timothy Crosley</name>
<email>timothy.crosley@gmail.com</email>
</author>
<published>2021-03-05T04:05:19+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/python-packages/isort.git/commit/?id=e09bbbcf07bf600c7d67cf794868e629681e3cca'/>
<id>e09bbbcf07bf600c7d67cf794868e629681e3cca</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
