delta/python-packages/kafka-python.git, branch dont-use-broker-errors-for-client-side-problems github.com: mumrah/kafka-python.git Stop using broker-errors for client-side problems 2018-11-18T00:23:37+00:00 Jeff Widman jeff@jeffwidman.com 2018-11-17T09:37:15+00:00 aad278f9dd299e276cb643eb31d984ef9121f36d `UnsupportedVersionError` is intended to indicate a server-side error: https://github.com/dpkp/kafka-python/blob/ba7372e44ffa1ee49fb4d5efbd67534393e944db/kafka/errors.py#L375-L378 So we should not be raising it for client-side errors. I realize that semantically this seems like the appropriate error to raise. However, this is confusing when debugging... for a real-life example, see https://github.com/Parsely/pykafka/issues/697. So I strongly feel that server-side errors should be kept separate from client-side errors, even if all the client is doing is proactively protecting against hitting a situation where the broker would return this error. 
`UnsupportedVersionError` is intended to indicate a server-side error:
https://github.com/dpkp/kafka-python/blob/ba7372e44ffa1ee49fb4d5efbd67534393e944db/kafka/errors.py#L375-L378

So we should not be raising it for client-side errors. I realize that
semantically this seems like the appropriate error to raise. However,
this is confusing when debugging... for a real-life example, see
https://github.com/Parsely/pykafka/issues/697. So I strongly feel that
server-side errors should be kept separate from client-side errors,
even if all the client is doing is proactively protecting against
hitting a situation where the broker would return this error.
Update requirements-dev to latest versions used on travis runs 2018-11-17T21:59:11+00:00 Dana Powers dana.powers@gmail.com 2018-11-17T21:59:11+00:00 7bd6b5da6d402565f25fce9e710be26b2d4cc125 






Pin pytest on 3.x -- we arent ready for pytest 4.0 yet
2018-11-17T21:56:51+00:00

Dana Powers
dana.powers@gmail.com

2018-11-17T21:56:51+00:00

eae0eddc57b16be5a83eb29fd85106b33ec22693












Use TypeError for invalid type
2018-11-17T08:41:24+00:00

Jeff Widman
jeff@jeffwidman.com

2018-11-13T21:58:51+00:00

21d68c98470eab6b9e7e5c934017af4a4fd24748












Update changelog
2018-11-13T01:37:24+00:00

Dana Powers
dana.powers@gmail.com

2018-11-13T01:37:24+00:00

f0ef99f0e280f672289edab58c7f4a42341c01ab












Migrate from `Unittest` to `pytest` (#1620)
2018-11-10T20:48:33+00:00

Jeff Widman
jeff@jeffwidman.com

2018-11-10T20:48:33+00:00

bb5bc1fcfc09c9c9994edbbae0af2ff6802c353d












raising logging level on messages signalling data loss (#1553)
2018-11-10T20:46:54+00:00

Alexander Sibiryakov
sibiryakov@users.noreply.github.com

2018-11-10T20:46:54+00:00

cd47701ba63fc77309066e27b73f50d0150e3e1b












set socket timeout for the wake_w (#1577)
2018-11-10T20:45:51+00:00

flaneur
me.ssword@gmail.com

2018-11-10T20:45:51+00:00

1c0e8942dc75837a2e43b93e0ed6700fb7752a03












(Attempt to) Fix deadlock between consumer and heartbeat (#1628)
2018-11-10T20:45:01+00:00

Dana Powers
dana.powers@gmail.com

2018-11-10T20:45:01+00:00

0a2ccba3cb1b8636f615a30821123720773a8dfa












Fix typo
2018-11-08T03:20:50+00:00

Jeff Widman
jeff@jeffwidman.com

2018-11-08T03:20:50+00:00

9d44e3cf8b6a75b11f1087282157aa48eba68a64