summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Most <twm@freecog.net>2016-02-26 17:37:41 -0800
committerTom Most <twm@freecog.net>2016-02-26 17:37:41 -0800
commit00d527f480299cc3c0298f3e4699c2f421d3fc64 (patch)
tree9a5905861e43832f0385a2c492aa4c5221d73017
parent59ac7d6ca663929fd95c30ce3c9fe6c805e54993 (diff)
downloadkafka-python-00d527f480299cc3c0298f3e4699c2f421d3fc64.tar.gz
Update base.py
Our app uses `SimpleProducer` and logs lots of these warnings (from line 438): producer.stop() called, but producer is not async This destructor appears to be the cause. (Also, is it wise to do a thread join from a destructor?)
-rw-r--r--kafka/producer/base.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/kafka/producer/base.py b/kafka/producer/base.py
index 9720390..2067c7e 100644
--- a/kafka/producer/base.py
+++ b/kafka/producer/base.py
@@ -471,5 +471,5 @@ class Producer(object):
self.stopped = True
def __del__(self):
- if not self.stopped:
+ if self.async and not self.stopped:
self.stop()