diff options
| author | Viktor Shlapakov <vshlapakov@gmail.com> | 2015-02-26 17:24:52 +0300 |
|---|---|---|
| committer | Viktor Shlapakov <vshlapakov@gmail.com> | 2015-06-03 11:22:47 +0300 |
| commit | 566e408da0aa7fb1bb74fae96231c94cc4a12e37 (patch) | |
| tree | 14904f0e7fbe0aaf785cb670ac37a1cbf8c6c4e2 | |
| parent | a9324f343e97ae3ceaa2acd480764818bb2b171e (diff) | |
| download | kafka-python-566e408da0aa7fb1bb74fae96231c94cc4a12e37.tar.gz | |
Fix: check failed reqs to retry only for positive limit
| -rw-r--r-- | kafka/producer/base.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/kafka/producer/base.py b/kafka/producer/base.py index 87d923a..8544d73 100644 --- a/kafka/producer/base.py +++ b/kafka/producer/base.py @@ -89,11 +89,11 @@ def _send_upstream(queue, client, codec, batch_time, batch_size, failed_reqs = ex.args[0] log.exception("Failed payloads count %s" % len(failed_reqs)) + # if no limit, retry all failed messages until success if retries_limit is None: - # retry all failed messages until success reqs_to_retry = failed_reqs - elif not retries_limit < 0: - # + # makes sense to check failed reqs only if we have a limit > 0 + elif retries_limit > 0: for req in failed_reqs: if retries_limit and req.retries < retries_limit: updated_req = req._replace(retries=req.retries+1) |