diff options
author | Dana Powers <dana.powers@gmail.com> | 2016-07-10 21:38:10 -0700 |
---|---|---|
committer | Dana Powers <dana.powers@gmail.com> | 2016-07-16 14:05:49 -0700 |
commit | fc5338bc5521ebed2a81357673f5665ddc000a7d (patch) | |
tree | 2b9ebe7414d186da36e39db770d033452e739365 | |
parent | c34d13879641d27cceb9403a4e6617152dfda0f3 (diff) | |
download | kafka-python-fc5338bc5521ebed2a81357673f5665ddc000a7d.tar.gz |
KAFKA-3785: Fetcher spending unnecessary time during metrics recording
-rw-r--r-- | kafka/consumer/fetcher.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/kafka/consumer/fetcher.py b/kafka/consumer/fetcher.py index 34ff4cb..9b36354 100644 --- a/kafka/consumer/fetcher.py +++ b/kafka/consumer/fetcher.py @@ -774,12 +774,12 @@ class FetchManagerMetrics(object): 'The maximum throttle time in ms'), Max()) def record_topic_fetch_metrics(self, topic, num_bytes, num_records): - metric_tags = {'topic': topic.replace('.', '_')} - # record bytes fetched name = '.'.join(['topic', topic, 'bytes-fetched']) bytes_fetched = self.metrics.get_sensor(name) if not bytes_fetched: + metric_tags = {'topic': topic.replace('.', '_')} + bytes_fetched = self.metrics.sensor(name) bytes_fetched.add(self.metrics.metric_name('fetch-size-avg', self.group_name, @@ -799,6 +799,8 @@ class FetchManagerMetrics(object): name = '.'.join(['topic', topic, 'records-fetched']) records_fetched = self.metrics.get_sensor(name) if not records_fetched: + metric_tags = {'topic': topic.replace('.', '_')} + records_fetched = self.metrics.sensor(name) records_fetched.add(self.metrics.metric_name('records-per-request-avg', self.group_name, |