diff options
| author | Dana Powers <dana.powers@gmail.com> | 2019-04-02 09:21:01 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-02 09:21:01 -0700 |
| commit | ed4cab65704fb5c1c5f0c1071590ca0a7b3fbf4e (patch) | |
| tree | 28cc9a86c08616b105624f5b9e5c36d1ba15692c | |
| parent | 6ca6f367f16cdbf056bc2b49c6b47e43f734c06a (diff) | |
| download | kafka-python-ed4cab65704fb5c1c5f0c1071590ca0a7b3fbf4e.tar.gz | |
Return connection state explicitly after close in connect() (#1778)
| -rw-r--r-- | kafka/conn.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kafka/conn.py b/kafka/conn.py index 5b199f8..94cf584 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -354,7 +354,7 @@ class BrokerConnection(object): next_lookup = self._next_afi_sockaddr() if not next_lookup: self.close(Errors.KafkaConnectionError('DNS failure')) - return + return self.state else: log.debug('%s: creating new socket', self) self._sock_afi, self._sock_addr = next_lookup @@ -409,6 +409,7 @@ class BrokerConnection(object): ' Disconnecting.', self, ret) errstr = errno.errorcode.get(ret, 'UNKNOWN') self.close(Errors.KafkaConnectionError('{} {}'.format(ret, errstr))) + return self.state # Needs retry else: @@ -443,6 +444,7 @@ class BrokerConnection(object): if time.time() > request_timeout + self.last_attempt: log.error('Connection attempt to %s timed out', self) self.close(Errors.KafkaConnectionError('timeout')) + return self.state return self.state |