summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWilliam Ting <wting@yelp.com>2015-03-09 14:23:26 -0700
committerDana Powers <dana.powers@rd.io>2015-05-17 18:03:10 -0700
commit01eb735af858f5bb1c67bf57cbdb0f0af665ba9b (patch)
tree977cba4e2cdf31a4880687690256b064f20a9e76
parentf020c45d539678152f41810bcc47f769d4b5c1fa (diff)
downloadkafka-python-01eb735af858f5bb1c67bf57cbdb0f0af665ba9b.tar.gz
Check vs None directly.
-rw-r--r--kafka/consumer/base.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/kafka/consumer/base.py b/kafka/consumer/base.py
index aef898a..f53217f 100644
--- a/kafka/consumer/base.py
+++ b/kafka/consumer/base.py
@@ -50,7 +50,7 @@ class Consumer(object):
self.client.load_metadata_for_topics(topic)
self.offsets = {}
- if not partitions:
+ if partitions is None:
partitions = self.client.get_partition_ids_for_topic(topic)
else:
assert all(isinstance(x, numbers.Integral) for x in partitions)
@@ -86,7 +86,7 @@ class Consumer(object):
if self.group is None:
raise ValueError('KafkaClient.group must not be None')
- if not partitions:
+ if partitions is None:
partitions = self.client.get_partition_ids_for_topic(self.topic)
responses = self.client.send_offset_fetch_request(
@@ -133,7 +133,7 @@ class Consumer(object):
return
reqs = []
- if not partitions: # commit all partitions
+ if partitions is None: # commit all partitions
partitions = self.offsets.keys()
for partition in partitions:
@@ -194,7 +194,7 @@ class Consumer(object):
Keyword Arguments:
partitions (list): list of partitions to check for, default is to check all
"""
- if not partitions:
+ if partitions is None:
partitions = self.offsets.keys()
total = 0