diff options
| author | Dana Powers <dana.powers@gmail.com> | 2016-09-20 17:03:38 -0700 |
|---|---|---|
| committer | Dana Powers <dana.powers@gmail.com> | 2016-12-17 10:13:03 -0800 |
| commit | 07e09c1c2ec6787fc7e4f3c2578d31b4a15d20bc (patch) | |
| tree | d11ea782a8ebd2f32a1b3a2d4cab55669ed46838 | |
| parent | 7690b1ab32b50ce3798c310648e7b69e46fafdbd (diff) | |
| download | kafka-python-07e09c1c2ec6787fc7e4f3c2578d31b4a15d20bc.tar.gz | |
Fixup doc references to max_in_flight_requests_per_connection
| -rw-r--r-- | kafka/conn.py | 2 | ||||
| -rw-r--r-- | kafka/producer/kafka.py | 2 | ||||
| -rw-r--r-- | kafka/producer/record_accumulator.py | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/kafka/conn.py b/kafka/conn.py index bbac554..247cff6 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -557,7 +557,7 @@ class BrokerConnection(object): return future def can_send_more(self): - """Return True unless there are max_in_flight_requests.""" + """Return True unless there are max_in_flight_requests_per_connection.""" max_ifrs = self.config['max_in_flight_requests_per_connection'] return len(self.in_flight_requests) < max_ifrs diff --git a/kafka/producer/kafka.py b/kafka/producer/kafka.py index 747f620..17f27ab 100644 --- a/kafka/producer/kafka.py +++ b/kafka/producer/kafka.py @@ -122,7 +122,7 @@ class KafkaProducer(object): to resend any record whose send fails with a potentially transient error. Note that this retry is no different than if the client resent the record upon receiving the error. Allowing retries - without setting max_in_flight_connections_per_connection to 1 will + without setting max_in_flight_requests_per_connection to 1 will potentially change the ordering of records because if two batches are sent to a single partition, and the first fails and is retried but the second succeeds, then the records in the second batch may diff --git a/kafka/producer/record_accumulator.py b/kafka/producer/record_accumulator.py index 7610fe2..965ddbe 100644 --- a/kafka/producer/record_accumulator.py +++ b/kafka/producer/record_accumulator.py @@ -354,7 +354,7 @@ class RecordAccumulator(object): * There is at least one partition that is not backing off its send * and those partitions are not muted (to prevent reordering if - max_in_flight_connections is set to 1) + max_in_flight_requests_per_connection is set to 1) * and any of the following are true: * The record set is full |