summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDana Powers <dana.powers@gmail.com>2017-04-10 12:38:02 -0700
committerDana Powers <dana.powers@gmail.com>2017-04-10 12:38:02 -0700
commit120410bcb41568dd3a754931aa8f3c55c8641aa9 (patch)
treecb58e1b543d6ebfbf970a4e748e4dbf43a4dc5ef
parenta503682ee6f71841db3e370f0169131c9653b1c4 (diff)
downloadkafka-python-120410bcb41568dd3a754931aa8f3c55c8641aa9.tar.gz
Follow-up to #1068: remove not-implemented comments
-rw-r--r--kafka/consumer/group.py2
-rw-r--r--kafka/producer/kafka.py2
2 files changed, 2 insertions, 2 deletions
diff --git a/kafka/consumer/group.py b/kafka/consumer/group.py
index 97df7a7..7fa5710 100644
--- a/kafka/consumer/group.py
+++ b/kafka/consumer/group.py
@@ -254,7 +254,7 @@ class KafkaConsumer(six.Iterator):
'ssl_password': None,
'api_version': None,
'api_version_auto_timeout_ms': 2000,
- 'connections_max_idle_ms': 9 * 60 * 1000, # Not implemented yet
+ 'connections_max_idle_ms': 9 * 60 * 1000,
'metric_reporters': [],
'metrics_num_samples': 2,
'metrics_sample_window_ms': 30000,
diff --git a/kafka/producer/kafka.py b/kafka/producer/kafka.py
index 22f60bd..3abadcc 100644
--- a/kafka/producer/kafka.py
+++ b/kafka/producer/kafka.py
@@ -266,7 +266,7 @@ class KafkaProducer(object):
'linger_ms': 0,
'partitioner': DefaultPartitioner(),
'buffer_memory': 33554432,
- 'connections_max_idle_ms': 9 * 60 * 1000, # not implemented yet
+ 'connections_max_idle_ms': 9 * 60 * 1000,
'max_block_ms': 60000,
'max_request_size': 1048576,
'metadata_max_age_ms': 300000,