diff options
author | Dana Powers <dana.powers@gmail.com> | 2016-04-07 16:09:07 -0700 |
---|---|---|
committer | Dana Powers <dana.powers@gmail.com> | 2016-04-08 09:23:57 -0700 |
commit | 2527ff30ce84452106a7a5cf7be0cff06bc921a0 (patch) | |
tree | 864c4d23b5111242706cd9d6191dbf8cc38978b3 | |
parent | e86b6d21bea284097398076e059f62eb53a896ca (diff) | |
download | kafka-python-2527ff30ce84452106a7a5cf7be0cff06bc921a0.tar.gz |
Drop timeout param from BrokerConnection.recv()
-rw-r--r-- | kafka/conn.py | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/kafka/conn.py b/kafka/conn.py index 8e3c657..cdf7a5e 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -4,7 +4,6 @@ import errno import logging import io from random import shuffle -from select import select import socket import struct from threading import local @@ -217,7 +216,7 @@ class BrokerConnection(object): max_ifrs = self.config['max_in_flight_requests_per_connection'] return len(self.in_flight_requests) < max_ifrs - def recv(self, timeout=0): + def recv(self): """Non-blocking network receive. Return response if available @@ -243,10 +242,6 @@ class BrokerConnection(object): self.config['request_timeout_ms'])) return None - readable, _, _ = select([self._sock], [], [], timeout) - if not readable: - return None - # Not receiving is the state of reading the payload header if not self._receiving: try: @@ -255,8 +250,6 @@ class BrokerConnection(object): self._rbuffer.write(self._sock.recv(4 - self._rbuffer.tell())) except ConnectionError as e: if six.PY2 and e.errno == errno.EWOULDBLOCK: - # This shouldn't happen after selecting above - # but just in case return None log.exception('%s: Error receiving 4-byte payload header -' ' closing socket', self) |