diff options
| author | Taras Voinarovskyi <voyn1991@gmail.com> | 2017-09-13 22:03:51 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-13 22:03:51 +0300 |
| commit | b1ae45c10d46e881492b0fd37f0919cac6d79224 (patch) | |
| tree | 2dd4f71b4c841bea4662c3926848c296666280e1 /kafka/client.py | |
| parent | 71efe2c2be3bd9729ec02df6bd6ce1b0cd6b4eba (diff) | |
| parent | 84aec293f7074b4fe46741cd2be694d1efd91386 (diff) | |
| download | kafka-python-b1ae45c10d46e881492b0fd37f0919cac6d79224.tar.gz | |
Merge pull request #1213 from dpkp/1212-stop-using-mutable-types-for-default-arg-values
Stop using mutable types for default arg values
Diffstat (limited to 'kafka/client.py')
| -rw-r--r-- | kafka/client.py | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/kafka/client.py b/kafka/client.py index 680c860..75b05bf 100644 --- a/kafka/client.py +++ b/kafka/client.py @@ -588,21 +588,21 @@ class SimpleClient(object): leader, None, None, None ) - def send_metadata_request(self, payloads=[], fail_on_error=True, + def send_metadata_request(self, payloads=(), fail_on_error=True, callback=None): encoder = KafkaProtocol.encode_metadata_request decoder = KafkaProtocol.decode_metadata_response return self._send_broker_unaware_request(payloads, encoder, decoder) - def send_consumer_metadata_request(self, payloads=[], fail_on_error=True, + def send_consumer_metadata_request(self, payloads=(), fail_on_error=True, callback=None): encoder = KafkaProtocol.encode_consumer_metadata_request decoder = KafkaProtocol.decode_consumer_metadata_response return self._send_broker_unaware_request(payloads, encoder, decoder) - def send_produce_request(self, payloads=[], acks=1, timeout=1000, + def send_produce_request(self, payloads=(), acks=1, timeout=1000, fail_on_error=True, callback=None): """ Encode and send some ProduceRequests @@ -652,7 +652,7 @@ class SimpleClient(object): if resp is not None and (not fail_on_error or not self._raise_on_response_error(resp))] - def send_fetch_request(self, payloads=[], fail_on_error=True, + def send_fetch_request(self, payloads=(), fail_on_error=True, callback=None, max_wait_time=100, min_bytes=4096): """ Encode and send a FetchRequest @@ -672,7 +672,7 @@ class SimpleClient(object): return [resp if not callback else callback(resp) for resp in resps if not fail_on_error or not self._raise_on_response_error(resp)] - def send_offset_request(self, payloads=[], fail_on_error=True, + def send_offset_request(self, payloads=(), fail_on_error=True, callback=None): resps = self._send_broker_aware_request( payloads, @@ -682,7 +682,7 @@ class SimpleClient(object): return [resp if not callback else callback(resp) for resp in resps if not fail_on_error or not self._raise_on_response_error(resp)] - def send_list_offset_request(self, payloads=[], fail_on_error=True, + def send_list_offset_request(self, payloads=(), fail_on_error=True, callback=None): resps = self._send_broker_aware_request( payloads, @@ -692,7 +692,7 @@ class SimpleClient(object): return [resp if not callback else callback(resp) for resp in resps if not fail_on_error or not self._raise_on_response_error(resp)] - def send_offset_commit_request(self, group, payloads=[], + def send_offset_commit_request(self, group, payloads=(), fail_on_error=True, callback=None): encoder = functools.partial(KafkaProtocol.encode_offset_commit_request, group=group) @@ -702,7 +702,7 @@ class SimpleClient(object): return [resp if not callback else callback(resp) for resp in resps if not fail_on_error or not self._raise_on_response_error(resp)] - def send_offset_fetch_request(self, group, payloads=[], + def send_offset_fetch_request(self, group, payloads=(), fail_on_error=True, callback=None): encoder = functools.partial(KafkaProtocol.encode_offset_fetch_request, @@ -713,7 +713,7 @@ class SimpleClient(object): return [resp if not callback else callback(resp) for resp in resps if not fail_on_error or not self._raise_on_response_error(resp)] - def send_offset_fetch_request_kafka(self, group, payloads=[], + def send_offset_fetch_request_kafka(self, group, payloads=(), fail_on_error=True, callback=None): encoder = functools.partial(KafkaProtocol.encode_offset_fetch_request, |